mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
Remove deprecated ActiveStorage::Downloading
This commit is contained in:
parent
426967c6f5
commit
92a8e1d7c5
3 changed files with 7 additions and 48 deletions
|
@ -1,3 +1,7 @@
|
||||||
|
* Remove deprecated `ActiveStorage::Downloading`.
|
||||||
|
|
||||||
|
*Rafael Mendonça França*
|
||||||
|
|
||||||
* Add per-environment configuration support
|
* Add per-environment configuration support
|
||||||
|
|
||||||
*Pietro Moro*
|
*Pietro Moro*
|
||||||
|
|
|
@ -1,47 +0,0 @@
|
||||||
# frozen_string_literal: true
|
|
||||||
|
|
||||||
require "tmpdir"
|
|
||||||
require "active_support/core_ext/string/filters"
|
|
||||||
|
|
||||||
module ActiveStorage
|
|
||||||
module Downloading
|
|
||||||
def self.included(klass)
|
|
||||||
ActiveSupport::Deprecation.warn <<~MESSAGE.squish, caller_locations(2)
|
|
||||||
ActiveStorage::Downloading is deprecated and will be removed in Active Storage 6.1.
|
|
||||||
Use ActiveStorage::Blob#open instead.
|
|
||||||
MESSAGE
|
|
||||||
end
|
|
||||||
|
|
||||||
private
|
|
||||||
# Opens a new tempfile in #tempdir and copies blob data into it. Yields the tempfile.
|
|
||||||
def download_blob_to_tempfile #:doc:
|
|
||||||
open_tempfile_for_blob do |file|
|
|
||||||
download_blob_to file
|
|
||||||
yield file
|
|
||||||
end
|
|
||||||
end
|
|
||||||
|
|
||||||
def open_tempfile_for_blob
|
|
||||||
tempfile = Tempfile.open([ "ActiveStorage", blob.filename.extension_with_delimiter ], tempdir)
|
|
||||||
|
|
||||||
begin
|
|
||||||
yield tempfile
|
|
||||||
ensure
|
|
||||||
tempfile.close!
|
|
||||||
end
|
|
||||||
end
|
|
||||||
|
|
||||||
# Efficiently downloads blob data into the given file.
|
|
||||||
def download_blob_to(file) #:doc:
|
|
||||||
file.binmode
|
|
||||||
blob.download { |chunk| file.write(chunk) }
|
|
||||||
file.flush
|
|
||||||
file.rewind
|
|
||||||
end
|
|
||||||
|
|
||||||
# Returns the directory in which tempfiles should be opened. Defaults to +Dir.tmpdir+.
|
|
||||||
def tempdir #:doc:
|
|
||||||
Dir.tmpdir
|
|
||||||
end
|
|
||||||
end
|
|
||||||
end
|
|
|
@ -240,6 +240,8 @@ Please refer to the [Changelog][active-storage] for detailed changes.
|
||||||
|
|
||||||
### Removals
|
### Removals
|
||||||
|
|
||||||
|
* Remove deprecated `ActiveStorage::Downloading`.
|
||||||
|
|
||||||
### Deprecations
|
### Deprecations
|
||||||
|
|
||||||
* Deprecate `Blob.create_after_upload` in favor of `Blob.create_and_upload`.
|
* Deprecate `Blob.create_after_upload` in favor of `Blob.create_and_upload`.
|
||||||
|
|
Loading…
Reference in a new issue