mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
Ensure ERB source begins with the encoding comment
This commit is contained in:
parent
9537fd0e3a
commit
94911c7af7
5 changed files with 34 additions and 7 deletions
|
@ -16,7 +16,9 @@ module ActionView
|
||||||
self.default_format = Mime::HTML
|
self.default_format = Mime::HTML
|
||||||
|
|
||||||
def compile(template)
|
def compile(template)
|
||||||
::ERB.new("<% __in_erb_template=true %>#{template.source}", nil, erb_trim_mode, '@output_buffer').src
|
magic = $1 if template.source =~ /\A(<%#.*coding:\s*(\S+)\s*-?%>)/
|
||||||
|
erb = "#{magic}<% __in_erb_template=true %>#{template.source}"
|
||||||
|
::ERB.new(erb, nil, erb_trim_mode, '@output_buffer').src
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -53,7 +53,11 @@ module ActionView
|
||||||
locals_code = locals.keys.map! { |key| "#{key} = local_assigns[:#{key}];" }.join
|
locals_code = locals.keys.map! { |key| "#{key} = local_assigns[:#{key}];" }.join
|
||||||
|
|
||||||
code = @handler.call(self)
|
code = @handler.call(self)
|
||||||
encoding_comment = $1 if code.sub!(/\A(#.*coding.*)\n/, '')
|
if code.sub!(/\A(#.*coding.*)\n/, '')
|
||||||
|
encoding_comment = $1
|
||||||
|
elsif defined?(Encoding) && Encoding.respond_to?(:default_external)
|
||||||
|
encoding_comment = "#coding:#{Encoding.default_external}"
|
||||||
|
end
|
||||||
|
|
||||||
source = <<-end_src
|
source = <<-end_src
|
||||||
def #{method_name}(local_assigns)
|
def #{method_name}(local_assigns)
|
||||||
|
|
1
actionpack/test/fixtures/test/utf8.html.erb
vendored
1
actionpack/test/fixtures/test/utf8.html.erb
vendored
|
@ -1,4 +1,3 @@
|
||||||
<%# encoding: utf-8 -%>
|
|
||||||
Русский текст
|
Русский текст
|
||||||
<%= "日".encoding %>
|
<%= "日".encoding %>
|
||||||
<%= @output_buffer.encoding %>
|
<%= @output_buffer.encoding %>
|
||||||
|
|
5
actionpack/test/fixtures/test/utf8_magic.html.erb
vendored
Normal file
5
actionpack/test/fixtures/test/utf8_magic.html.erb
vendored
Normal file
|
@ -0,0 +1,5 @@
|
||||||
|
<%# encoding: utf-8 -%>
|
||||||
|
Русский текст
|
||||||
|
<%= "日".encoding %>
|
||||||
|
<%= @output_buffer.encoding %>
|
||||||
|
<%= __ENCODING__ %>
|
|
@ -247,10 +247,27 @@ module RenderTestCases
|
||||||
end
|
end
|
||||||
|
|
||||||
if '1.9'.respond_to?(:force_encoding)
|
if '1.9'.respond_to?(:force_encoding)
|
||||||
def test_render_utf8_template
|
def test_render_utf8_template_with_magic_comment
|
||||||
result = @view.render(:file => "test/utf8.html.erb", :layouts => "layouts/yield")
|
with_external_encoding Encoding::ASCII_8BIT do
|
||||||
assert_equal "Русский текст\nUTF-8\nUTF-8\nUTF-8\n", result
|
result = @view.render(:file => "test/utf8_magic.html.erb", :layouts => "layouts/yield")
|
||||||
assert_equal Encoding::UTF_8, result.encoding
|
assert_equal "Русский текст\nUTF-8\nUTF-8\nUTF-8\n", result
|
||||||
|
assert_equal Encoding::UTF_8, result.encoding
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
def test_render_utf8_template_with_default_external_encoding
|
||||||
|
with_external_encoding Encoding::UTF_8 do
|
||||||
|
result = @view.render(:file => "test/utf8.html.erb", :layouts => "layouts/yield")
|
||||||
|
assert_equal "Русский текст\nUTF-8\nUTF-8\nUTF-8\n", result
|
||||||
|
assert_equal Encoding::UTF_8, result.encoding
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
def with_external_encoding(encoding)
|
||||||
|
old, Encoding.default_external = Encoding.default_external, encoding
|
||||||
|
yield
|
||||||
|
ensure
|
||||||
|
Encoding.default_external = old
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
Loading…
Reference in a new issue