1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00

generate ApplicationJob if it does not already exist

ActiveJob jobs now inherit from ApplicationJob by default.
However, when updating to Rails 5 from the old Rails,
since there is a possibility that ApplicationJob does not exist.
This commit is contained in:
yuuji.yaginuma 2016-03-12 15:00:55 +09:00
parent 520e81ba5d
commit 9a9fc01af0
4 changed files with 39 additions and 0 deletions

View file

@ -17,7 +17,22 @@ module Rails # :nodoc:
def create_job_file
template 'job.rb', File.join('app/jobs', class_path, "#{file_name}_job.rb")
in_root do
if self.behavior == :invoke && !File.exist?(application_job_file_name)
template 'application_job.rb', application_job_file_name
end
end
end
private
def application_job_file_name
@application_job_file_name ||= if mountable_engine?
"app/jobs/#{namespaced_path}/application_job.rb"
else
'app/jobs/application_job.rb'
end
end
end
end
end

View file

@ -0,0 +1,4 @@
<% module_namespacing do -%>
class ApplicationJob < ActiveJob::Base
end
<% end -%>

View file

@ -26,4 +26,11 @@ class JobGeneratorTest < Rails::Generators::TestCase
assert_match(/queue_as :admin/, job)
end
end
def test_application_job_skeleton_is_created
run_generator ["refresh_counters"]
assert_file "app/jobs/application_job.rb" do |job|
assert_match(/class ApplicationJob < ActiveJob::Base/, job)
end
end
end

View file

@ -669,6 +669,19 @@ class PluginGeneratorTest < Rails::Generators::TestCase
end
end
def test_generate_application_job_when_does_not_exist_in_mountable_engine
run_generator [destination_root, '--mountable']
FileUtils.rm "#{destination_root}/app/jobs/bukkits/application_job.rb"
capture(:stdout) do
`#{destination_root}/bin/rails g job refresh_counters`
end
assert_file "#{destination_root}/app/jobs/bukkits/application_job.rb" do |record|
assert_match(/module Bukkits/, record)
assert_match(/class ApplicationJob < ActiveJob::Base/, record)
end
end
def test_after_bundle_callback
path = 'http://example.org/rails_template'
template = %{ after_bundle { run 'echo ran after_bundle' } }