kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Remove deprecated calls to SelectManager#wheres with no replacement

Browse source
This commit is contained in:
Vipul A M 2013-07-14 21:17:57 +05:30
parent a8f6662def
commit 9cbfc8a370
2 changed files with 0 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
lib/arel/select_manager.rb
View file

@ -161,11 +161,6 @@ module Arel
@ast.orders @ast.orders
end end
def wheres
warn "#{caller[0]}: SelectManager#wheres is deprecated and will be removed in Arel 4.0.0 with no replacement"
Compatibility::Wheres.new @engine.connection, @ctx.wheres
end
def where_sql def where_sql
return if @ctx.wheres.empty? return if @ctx.wheres.empty?

18
test/test_activerecord_compat.rb
View file

@ -1,18 +0,0 @@
require 'helper'
module Arel
describe 'activerecord compatibility' do
describe 'select manager' do
it 'provides wheres' do
table = Table.new :users
manager = Arel::SelectManager.new Table.engine
manager.where table[:id].eq 1
manager.where table[:name].eq 'Aaron'
manager.wheres.map { |x|
x.value
}.join(', ').must_equal "\"users\".\"id\" = 1, \"users\".\"name\" = 'Aaron'"
end
end
end
end