kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Fix the turbolinks npm -> github reference

Browse source 
Bug in https://github.com/rails/rails/pull/42263

You can replicate this by doing `rails new --main` with that PR.

This now uses the correct github reference, per the [npm docs](https://docs.npmjs.com/cli/v7/configuring-npm/package-json#github-urls).

Co-authored-by: Zachary Scott <zzakscott@gmail.com>
This commit is contained in:
Alex Ghiculescu 2021-06-21 17:18:40 -05:00
parent d6a1cff4e4
commit 9d9969f815
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
railties/lib/rails/generators/app_base.rb
View file

@ -326,7 +326,7 @@ module Rails
# since Turbolinks is deprecated, let's just always point to main.
# expect this to be replaced with Hotwire at some point soon.
if options.main? || options.edge?
"git://github.com/turbolinks/turbolinks.git#main"
"turbolinks/turbolinks#master"
else
"^5.2.0"
end

2
railties/test/generators/app_generator_test.rb
View file

@ -551,7 +551,7 @@ class AppGeneratorTest < Rails::Generators::TestCase
assert_match(/"@rails\/ujs": "latest"/, content)
assert_match(/"@rails\/activestorage": "latest"/, content)
assert_match(/"@rails\/actioncable": "latest"/, content)
assert_match(/"turbolinks": "git:\/\/github.com\/turbolinks\/turbolinks.git#main"/, content)
assert_match(/"turbolinks": "turbolinks\/turbolinks#master"/, content)
end
end