1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00

calling unsafe methods which don't return a string shouldn't fail

This commit is contained in:
Damien Mathieu 2011-06-17 18:17:28 +02:00
parent 0dd32e8edb
commit 9fadf385d8
2 changed files with 6 additions and 2 deletions

View file

@ -137,8 +137,8 @@ module ActiveSupport #:nodoc:
UNSAFE_STRING_METHODS.each do |unsafe_method|
class_eval <<-EOT, __FILE__, __LINE__
def #{unsafe_method}(*args)
super.to_str
def #{unsafe_method}(*args, &block)
to_str.#{unsafe_method}(*args, &block)
end
def #{unsafe_method}!(*args)

View file

@ -104,4 +104,8 @@ class SafeBufferTest < ActiveSupport::TestCase
@buffer.safe_concat "BUSTED"
end
end
test "should not fail if the returned object is not a string" do
assert_kind_of Enumerator, @buffer.gsub(/.*/)
end
end