kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

AR::Relation#pluck: improve to work with joins

Browse source
This commit is contained in:
Bogdan Gusiev 2012-02-08 16:37:27 +02:00
parent 17497e5c55
commit a379cb2fb5
2 changed files with 14 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
activerecord/lib/active_record/relation/calculations.rb
View file

@ -177,6 +177,9 @@ module ActiveRecord
# Person.where(:confirmed => true).limit(5).pluck(:id)
#
def pluck(column_name)
if column_name.is_a?(Symbol) && column_names.include?(column_name.to_s)
column_name = "#{table_name}.#{column_name}"
end
klass.connection.select_all(select(column_name).arel).map! do |attributes|
klass.type_cast_attribute(attributes.keys.first, klass.initialize_attributes(attributes))
end

11
activerecord/test/cases/calculations_test.rb
View file

@ -478,4 +478,15 @@ class CalculationsTest < ActiveRecord::TestCase
def test_pluck_with_qualified_column_name
assert_equal [1,2,3,4], Topic.order(:id).pluck("topics.id")
end
def test_pluck_auto_table_name_prefix
c = Company.create!(:name => "test", :contracts => [Contract.new])
assert_equal [c.id], Company.joins(:contracts).pluck(:id)
end
def test_pluck_not_auto_table_name_prefix_if_column_joined
c = Company.create!(:name => "test", :contracts => [Contract.new(:developer_id => 7)])
# No chance for typecast here
assert_equal ["7"], Company.joins(:contracts).pluck(:developer_id)
end
end