1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00

All assets, including images, audio, and video, now uses the asset pipeline when its on

This commit is contained in:
David Heinemeier Hansson 2011-04-19 18:07:14 +02:00
parent dca31b9224
commit a3a5c7eba3
4 changed files with 44 additions and 8 deletions

View file

@ -274,7 +274,11 @@ module ActionView
# The alias +path_to_image+ is provided to avoid that. Rails uses the alias internally, and
# plugin authors are encouraged to do so.
def image_path(source)
asset_paths.compute_public_path(source, 'images')
if config.use_sprockets
sprockets_asset_path(source)
else
asset_paths.compute_public_path(source, 'images')
end
end
alias_method :path_to_image, :image_path # aliased to avoid conflicts with an image_path named route
@ -289,7 +293,11 @@ module ActionView
# video_path("/trailers/hd.avi") # => /trailers/hd.avi
# video_path("http://www.railsapplication.com/vid/hd.avi") # => http://www.railsapplication.com/vid/hd.avi
def video_path(source)
asset_paths.compute_public_path(source, 'videos')
if config.use_sprockets
sprockets_asset_path(source)
else
asset_paths.compute_public_path(source, 'videos')
end
end
alias_method :path_to_video, :video_path # aliased to avoid conflicts with a video_path named route
@ -304,7 +312,11 @@ module ActionView
# audio_path("/sounds/horse.wav") # => /sounds/horse.wav
# audio_path("http://www.railsapplication.com/sounds/horse.wav") # => http://www.railsapplication.com/sounds/horse.wav
def audio_path(source)
asset_paths.compute_public_path(source, 'audios')
if config.use_sprockets
sprockets_asset_path(source)
else
asset_paths.compute_public_path(source, 'audios')
end
end
alias_method :path_to_audio, :audio_path # aliased to avoid conflicts with an audio_path named route

View file

@ -3,8 +3,12 @@ require 'uri'
module ActionView
module Helpers
module SprocketsHelper
def sprockets_asset_path(source, default_ext = nil)
compute_sprockets_path(source, 'assets', default_ext)
end
def sprockets_javascript_path(source)
compute_sprockets_path source, 'assets', 'js'
sprockets_asset_path(source, 'js')
end
def sprockets_javascript_include_tag(source, options = {})
@ -17,9 +21,9 @@ module ActionView
end
def sprockets_stylesheet_path(source)
compute_sprockets_path source, 'assets', 'css'
sprockets_asset_path(source, 'css')
end
def sprockets_stylesheet_link_tag(source, options = {})
options = {
'rel' => "stylesheet",
@ -31,13 +35,14 @@ module ActionView
tag 'link', options
end
private
def compute_sprockets_path(source, dir, default_ext)
def compute_sprockets_path(source, dir, default_ext = nil)
source = source.to_s
return source if URI.parse(source).host
# Add /javscripts to relative paths
# Add /assets to relative paths
if source[0] != ?/
source = "/#{dir}/#{source}"
end

Binary file not shown.

After

Width:  |  Height:  |  Size: 6.5 KiB

View file

@ -22,6 +22,7 @@ class SprocketsHelperTest < ActionView::TestCase
@assets = Sprockets::Environment.new
@assets.paths << FIXTURES.join("sprockets/app/javascripts")
@assets.paths << FIXTURES.join("sprockets/app/stylesheets")
@assets.paths << FIXTURES.join("sprockets/app/images")
config.perform_caching = true
end
@ -30,6 +31,24 @@ class SprocketsHelperTest < ActionView::TestCase
"http://www.example.com"
end
test "asset path" do
assert_equal "/assets/logo-9c0a079bdd7701d7e729bd956823d153.png",
sprockets_asset_path("logo.png")
assert_equal "/images/logo",
sprockets_asset_path("/images/logo")
assert_equal "/images/logo.gif",
sprockets_asset_path("/images/logo.gif")
assert_equal "/dir/audio",
sprockets_asset_path("/dir/audio")
assert_equal "http://www.example.com/video/play",
sprockets_asset_path("http://www.example.com/video/play")
assert_equal "http://www.example.com/video/play.mp4",
sprockets_asset_path("http://www.example.com/video/play.mp4")
end
test "javascript path" do
assert_equal "/assets/application-d41d8cd98f00b204e9800998ecf8427e.js",
sprockets_javascript_path(:application)