kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Remove frozen_string_literal from Action Cable's template files

Browse source 
Related to 837f602fa1

Fix the testing guide.
This commit is contained in:
bogdanvlviv 2019-01-16 15:14:35 +00:00
parent d67863af39
commit a43052cbbc
No known key found for this signature in database
GPG key ID: E4ACD76A6DB6DFDD
3 changed files with 4 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
actioncable/lib/rails/generators/test_unit/templates/channel_test.rb.tt
View file

@ -1,5 +1,3 @@
# frozen_string_literal: true
require "test_helper"
class <%= class_name %>ChannelTest < ActionCable::Channel::TestCase

10
guides/source/testing.md
View file

@ -1735,14 +1735,14 @@ Testing Action Cable
--------------------
Since Action Cable is used at different levels inside your application,
you'll need to test both the channels and connection classes themsleves and that other
you'll need to test both the channels, connection classes themselves, and that other
entities broadcast correct messages.
### Connection Test Case
By default, when you generate new Rails application with Action Cable, a test for the base connection class (`ApplicationCable::Connection`) is generated as well under `test/channels/application_cable` directory.
Connection tests aim to check whether a connection's identifiers gets assigned properly
Connection tests aim to check whether a connection's identifiers get assigned properly
or that any improper connection requests are rejected. Here is an example:
```ruby
@ -1765,9 +1765,8 @@ end
You can also specify request cookies the same way you do in integration tests:
```ruby
test "connects with_cookies" do
test "connects with cookies" do
cookies.signed[:user_id] = "42"
connect
@ -1778,7 +1777,6 @@ end
See the API documentation for [`AcionCable::Connection::TestCase`](http://api.rubyonrails.org/classes/ActionCable/Connection/TestCase.html) for more information.
### Channel Test Case
By default, when you generate a channel, an associated test will be generated as well
@ -1823,7 +1821,7 @@ See the API documentation for [`AcionCable::Channel::TestCase`](http://api.rubyo
Action Cable ships with a bunch of custom assertions that can be used to lessen the verbosity of tests. For a full list of available assertions, see the API documentation for [`ActionCable::TestHelper`](http://api.rubyonrails.org/classes/ActionCable/TestHelper.html).
It's a good practice to ensure that the correct message has been broadcasted inside another components (e.g. inside your controllers). This is precisely where
It's a good practice to ensure that the correct message has been broadcasted inside other components (e.g. inside your controllers). This is precisely where
the custom assertions provided by Action Cable are pretty useful. For instance,
within a model:

2
railties/lib/rails/generators/rails/app/templates/test/channels/application_cable/connection_test.rb.tt
View file

@ -1,5 +1,3 @@
# frozen_string_literal: true
require "test_helper"
class ApplicationCable::ConnectionTest < ActionCable::Connection::TestCase