kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Only invoke the default block for mattr_accessor once so that it does not cause issues if it is not idempotent

Browse source
This commit is contained in:
Lachlan Sylvester 2015-08-07 20:05:02 +10:00
parent 4b91db5b12
commit a51dad1c52
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
activesupport/lib/active_support/core_ext/module/attribute_accessors.rb
View file

@ -206,7 +206,7 @@ class Module
# Person.class_variable_get("@@hair_colors") # => [:brown, :black, :blonde, :red] # Person.class_variable_get("@@hair_colors") # => [:brown, :black, :blonde, :red]
def mattr_accessor(*syms, &blk) def mattr_accessor(*syms, &blk)
mattr_reader(*syms, &blk) mattr_reader(*syms, &blk)
mattr_writer(*syms, &blk) mattr_writer(*syms)
end end
alias :cattr_accessor :mattr_accessor alias :cattr_accessor :mattr_accessor
end end

6
activesupport/test/core_ext/module/attribute_accessor_test.rb
View file

@ -76,4 +76,10 @@ class ModuleAttributeAccessorTest < ActiveSupport::TestCase
assert_equal 'default_reader_value', @module.defr assert_equal 'default_reader_value', @module.defr
assert_equal 'default_writer_value', @module.class_variable_get('@@defw') assert_equal 'default_writer_value', @module.class_variable_get('@@defw')
end end
def test_should_not_invoke_default_value_block_multiple_times
count = 0
@module.cattr_accessor(:defcount){ count += 1 }
assert_equal 1, count
end
end end