kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Merge pull request #23345 from yui-knk/warning_when_composite_primary_key_is_detected

Browse source 
Warn if `AR.primary_key` is called for a table who has composite prim…
This commit is contained in:
Rafael França 2016-01-30 12:21:52 -05:00
commit a59212709c
2 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb
View file

@ -125,6 +125,12 @@ module ActiveRecord
# Returns just a table's primary key
def primary_key(table_name)
pks = primary_keys(table_name)
warn <<-WARNING.strip_heredoc if pks.count > 1
WARNING: Rails does not support composite primary key.
#{table_name} has composite primary key. Composite primary key is ignored.
WARNING
pks.first if pks.one?
end

7
activerecord/test/cases/primary_keys_test.rb
View file

@ -260,6 +260,13 @@ class CompositePrimaryKeyTest < ActiveRecord::TestCase
assert_equal ["region", "code"], @connection.primary_keys("barcodes")
end
def test_primary_key_issues_warning
warning = capture(:stderr) do
@connection.primary_key("barcodes")
end
assert_match(/WARNING: Rails does not support composite primary key\./, warning)
end
def test_collectly_dump_composite_primary_key
schema = dump_table_schema "barcodes"
assert_match %r{create_table "barcodes", primary_key: \["region", "code"\]}, schema