From a628dd5ac49987207f84c38c899900acb06abaaf Mon Sep 17 00:00:00 2001 From: Xavier Noria Date: Sun, 24 Feb 2013 01:22:45 +0100 Subject: [PATCH] Revert "prevent minitest from printing a --seed run option" Reason: on a second thought, minitest prints a seed as run option regardless of the test order, and it actually calls srand, so albeit it might be misleading I believe, it is the way it is and should be left that way. This reverts commit c15862ae0cb876d745609170f0f90a9bb9b5e0ae. --- activesupport/lib/active_support/test_case.rb | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/activesupport/lib/active_support/test_case.rb b/activesupport/lib/active_support/test_case.rb index f4b162eafb..8b392c36d0 100644 --- a/activesupport/lib/active_support/test_case.rb +++ b/activesupport/lib/active_support/test_case.rb @@ -16,16 +16,6 @@ begin rescue LoadError end -# FIXME: We force sorted test order below, but minitest includes --seed SEED in -# the printed run options, which could be misleading, since users could assume -# from that trace that tests are being randomized. -MiniTest::Unit.class_eval do - alias original_help help - def help - original_help.sub(/--seed\s+\d+\s*/, '') - end -end - module ActiveSupport class TestCase < ::MiniTest::Unit::TestCase Assertion = MiniTest::Assertion @@ -36,8 +26,8 @@ module ActiveSupport yield if $tags[tag] end - # FIXME: We have tests that depend on run order, we should fix that and - # remove this method (and remove the MiniTest::Unit help hack above). + # FIXME: we have tests that depend on run order, we should fix that and + # remove this method. def self.test_order # :nodoc: :sorted end