kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Remove delegation of missing methods in a relation to private methods of the class

Browse source
This commit is contained in:
Rafael Mendonça França 2019-01-14 21:53:13 -05:00
parent f59b08119b
commit a7becf147a
No known key found for this signature in database
GPG key ID: FC23B6D0F1EEE948
3 changed files with 4 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
activerecord/CHANGELOG.md
View file

@ -1,3 +1,7 @@
* Remove delegation of missing methods in a relation to private methods of the class.
*Rafael Mendonça França*
* Deprecate `config.activerecord.sqlite3.represent_boolean_as_integer`.
*Rafael Mendonça França*

5
activerecord/lib/active_record/relation/delegation.rb
View file

@ -112,11 +112,6 @@ module ActiveRecord
if @klass.respond_to?(method)
self.class.delegate_to_scoped_klass(method)
scoping { @klass.public_send(method, *args, &block) }
elsif @delegate_to_klass && @klass.respond_to?(method, true)
ActiveSupport::Deprecation.warn \
"Delegating missing #{method} method to #{@klass}. " \
"Accessibility of private/protected class methods in :scope is deprecated and will be removed in Rails 6.0."
@klass.send(method, *args, &block)
elsif arel.respond_to?(method)
ActiveSupport::Deprecation.warn \
"Delegating #{method} to arel is deprecated and will be removed in Rails 6.0."

7
activerecord/test/cases/scoping/named_scoping_test.rb
View file

@ -303,13 +303,6 @@ class NamedScopingTest < ActiveRecord::TestCase
assert_equal "lifo", topic.author_name
end
def test_deprecated_delegating_private_method
assert_deprecated do
scope = Topic.all.by_private_lifo
assert_not scope.instance_variable_get(:@delegate_to_klass)
end
end
def test_reserved_scope_names
klass = Class.new(ActiveRecord::Base) do
self.table_name = "topics"