From a7faef6869c04fea002855a667362a13ba6075de Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafael=20Mendon=C3=A7a=20Fran=C3=A7a?= Date: Thu, 29 Oct 2020 16:33:37 +0000 Subject: [PATCH] Remove deprecated `ActiveSupport::Notifications::Instrumenter#end=` --- activesupport/CHANGELOG.md | 4 ++++ .../lib/active_support/notifications/instrumenter.rb | 5 ----- guides/source/6_1_release_notes.md | 2 ++ 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/activesupport/CHANGELOG.md b/activesupport/CHANGELOG.md index 694e5f91b9..a0e53b9bac 100644 --- a/activesupport/CHANGELOG.md +++ b/activesupport/CHANGELOG.md @@ -1,3 +1,7 @@ +* Remove deprecated `ActiveSupport::Notifications::Instrumenter#end=`. + + *Rafael Mendonça França* + * Deprecate `ActiveSupport::Multibyte::Unicode.default_normalization_form`. *Rafael Mendonça França* diff --git a/activesupport/lib/active_support/notifications/instrumenter.rb b/activesupport/lib/active_support/notifications/instrumenter.rb index 72f977b253..e1a9fe349c 100644 --- a/activesupport/lib/active_support/notifications/instrumenter.rb +++ b/activesupport/lib/active_support/notifications/instrumenter.rb @@ -82,11 +82,6 @@ module ActiveSupport @allocation_count_finish = now_allocations end - def end=(ending) - ActiveSupport::Deprecation.deprecation_warning(:end=, :finish!) - @end = ending - end - # Returns the CPU time (in milliseconds) passed since the call to # +start!+ and the call to +finish!+ def cpu_time diff --git a/guides/source/6_1_release_notes.md b/guides/source/6_1_release_notes.md index 880380b315..2bcf18ca5e 100644 --- a/guides/source/6_1_release_notes.md +++ b/guides/source/6_1_release_notes.md @@ -312,6 +312,8 @@ Please refer to the [Changelog][active-support] for detailed changes. `ActiveSupport::Multibyte::Unicode.downcase`, `ActiveSupport::Multibyte::Unicode.upcase` and `ActiveSupport::Multibyte::Unicode.swapcase`. +* Remove deprecated `ActiveSupport::Notifications::Instrumenter#end=`. + ### Deprecations * Deprecate `ActiveSupport::Multibyte::Unicode.default_normalization_form`.