kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Merge pull request #36045 from yfxie/fix-normalize-the-hash-of-transformations

Browse source 
ActiveStorage - normalize the hash of transformations
This commit is contained in:
George Claghorn 2019-04-21 16:07:54 -04:00 committed by GitHub
commit a89e9cccb2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
activestorage/app/models/active_storage/variation.rb
View file

@ -40,7 +40,7 @@ class ActiveStorage::Variation
end
def initialize(transformations)
@transformations = transformations
@transformations = transformations.deep_symbolize_keys
end
# Accepts a File object, performs the +transformations+ against it, and

8
activestorage/test/models/variant_test.rb
View file

@ -4,6 +4,14 @@ require "test_helper"
require "database/setup"
class ActiveStorage::VariantTest < ActiveSupport::TestCase
test "variations have the same key for different types of the same transformation" do
blob = create_file_blob(filename: "racecar.jpg")
variant_a = blob.variant(resize: "100x100")
variant_b = blob.variant("resize" => "100x100")
assert_equal variant_a.key, variant_b.key
end
test "resized variation of JPEG blob" do
blob = create_file_blob(filename: "racecar.jpg")
variant = blob.variant(resize: "100x100").processed