From 801a1516d0a219ce530a45f0a2e65a35b04c30eb Mon Sep 17 00:00:00 2001 From: Yasuo Honda Date: Mon, 5 May 2014 23:10:38 +0900 Subject: [PATCH] Support to add the casting node to the AST at build time Ref https://github.com/rails/arel/commit/93d72131bcc24ccb5536bec672d2dac94f8de651 --- lib/arel/visitors/oracle.rb | 2 +- test/visitors/test_oracle.rb | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/arel/visitors/oracle.rb b/lib/arel/visitors/oracle.rb index 699b52fe9a..8a80faaa97 100644 --- a/lib/arel/visitors/oracle.rb +++ b/lib/arel/visitors/oracle.rb @@ -17,7 +17,7 @@ module Arel if o.limit && o.offset o = o.dup - limit = o.limit.expr.to_i + limit = o.limit.expr.expr offset = o.offset o.offset = nil collector << " diff --git a/test/visitors/test_oracle.rb b/test/visitors/test_oracle.rb index bb0fe404e8..9111a266cf 100644 --- a/test/visitors/test_oracle.rb +++ b/test/visitors/test_oracle.rb @@ -100,7 +100,7 @@ module Arel it 'creates a different subquery when there is an offset' do stmt = Nodes::SelectStatement.new - stmt.limit = Nodes::Limit.new(10) + stmt.limit = Nodes::Limit.new(Nodes.build_quoted(10)) stmt.offset = Nodes::Offset.new(10) sql = compile stmt sql.must_be_like %{ @@ -115,7 +115,7 @@ module Arel it 'is idempotent with different subquery' do stmt = Nodes::SelectStatement.new - stmt.limit = Nodes::Limit.new(10) + stmt.limit = Nodes::Limit.new(Nodes.build_quoted(10)) stmt.offset = Nodes::Offset.new(10) sql = compile stmt sql2 = compile stmt