Merge pull request #17487 from pabloh/avoid_allocations

Avoid unnecessary allocations and method calls

activerecord/lib/active_record/associations/has_many_through_association.rb

@@ -161,7 +161,7 @@ module ActiveRecord
             if scope.klass.primary_key
               count = scope.destroy_all.length
             else
-              scope.to_a.each do |record|
+              scope.each do |record|
                 record._run_destroy_callbacks
               end
 

activerecord/lib/active_record/connection_adapters/mysql_adapter.rb

@@ -88,7 +88,7 @@ module ActiveRecord
         end
 
         def clear
-          cache.values.each do |hash|
+          cache.each_value do |hash|
             hash[:stmt].close
           end
           cache.clear

activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb

@@ -115,7 +115,7 @@ module ActiveRecord
         end
 
         def clear
-          cache.values.each do |hash|
+          cache.each_value do |hash|
             dealloc hash[:stmt]
           end
           cache.clear

activerecord/lib/active_record/fixtures.rb

@@ -649,7 +649,7 @@ module ActiveRecord
               model_class
             end
 
-          reflection_class._reflections.values.each do |association|
+          reflection_class._reflections.each_value do |association|
             case association.macro
             when :belongs_to
               # Do not replace association name with association foreign key if they are named the same

activesupport/lib/active_support/dependencies/autoload.rb

@@ -67,7 +67,7 @@ module ActiveSupport
     end
 
     def eager_load!
-      @_autoloads.values.each { |file| require file }
+      @_autoloads.each_value { |file| require file }
     end
 
     def autoloads