kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

don't establish a new connection when testing with sqlite3_mem.

Browse source 
This fixes broken `rake test_sqlite3_mem` suite for Active Record.
The problem is that that the old database with the schema is lost
when establishing a new connection. Upon reconnting we are left
with a blank database and tests down the line start failing.
This commit is contained in:
Yves Senn 2014-01-14 18:00:58 +01:00
parent 93b38d54df
commit b23330745b
1 changed files with 21 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
activerecord/test/cases/adapters/sqlite3/sqlite3_adapter_test.rb
View file

@ -34,6 +34,8 @@ module ActiveRecord
end
def test_connect_with_url
skip "can't establish new connection when using memory db" if in_memory_db?
begin
original_connection = ActiveRecord::Base.remove_connection
tf = Tempfile.open 'whatever'
url = "sqlite3://#{tf.path}"
@ -44,8 +46,11 @@ module ActiveRecord
tf.unlink
ActiveRecord::Base.establish_connection(original_connection)
end
end
def test_connect_memory_with_url
skip "can't establish new connection when using memory db" if in_memory_db?
begin
original_connection = ActiveRecord::Base.remove_connection
url = "sqlite3:///:memory:"
ActiveRecord::Base.establish_connection(url)
@ -53,6 +58,7 @@ module ActiveRecord
ensure
ActiveRecord::Base.establish_connection(original_connection)
end
end
def test_valid_column
column = @conn.columns('items').find { |col| col.name == 'id' }