kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Fix arity warning for template handlers

Browse source 
Mainly to help with knowning which template is reponsible for the
warning.

handler.class # => Class

handler.to_s # => Coffee::Rails::TemplateHandler

Before:

Change:
  >> Class#call(template)
To:
  >> Class#call(template, source)

After:

Change:
  >> Coffee::Rails::TemplateHandler.call(template)
To:
  >> Coffee::Rails::TemplateHandler.call(template, source)
This commit is contained in:
localhostdotdev 2019-04-04 18:59:33 +02:00
parent dc45130c44
commit b2b2f70f1f
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
actionview/lib/action_view/template/handlers.rb
View file

@ -45,12 +45,12 @@ module ActionView #:nodoc:
unless params.find_all { |type, _| type == :req || type == :opt }.length >= 2 unless params.find_all { |type, _| type == :req || type == :opt }.length >= 2
ActiveSupport::Deprecation.warn <<~eowarn ActiveSupport::Deprecation.warn <<~eowarn
Single arity template handlers are deprecated. Template handlers must Single arity template handlers are deprecated. Template handlers must
now accept two parameters, the view object and the source for the view object. now accept two parameters, the view object and the source for the view object.
Change: Change:
>> #{handler.class}#call(#{params.map(&:last).join(", ")}) >> #{handler}.call(#{params.map(&:last).join(", ")})
To: To:
>> #{handler.class}#call(#{params.map(&:last).join(", ")}, source) >> #{handler}.call(#{params.map(&:last).join(", ")}, source)
eowarn eowarn
handler = LegacyHandlerWrapper.new(handler) handler = LegacyHandlerWrapper.new(handler)
end end