kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Assign config on base instead of on @controller.

Browse source 
In some test runs `ActionController::Base.enable_fragment_cache_logging` would be false,
based on the test order.

Turns out it was off because we assigned the config to the `@controller` variable, and
not on `ActionController::Base`.

The test failure was reproducible with, and now passes after this:

```
bin/test test/controller/log_subscriber_test.rb --seed 19918
```
This commit is contained in:
Kasper Timm Hansen 2016-08-07 19:59:13 +02:00
parent 6530fe6a25
commit b377fc067d
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
actionpack/test/controller/log_subscriber_test.rb
View file

@ -92,7 +92,7 @@ class ACLogSubscriberTest < ActionController::TestCase
def setup
super
@controller.enable_fragment_cache_logging = true
ActionController::Base.enable_fragment_cache_logging = true
@old_logger = ActionController::Base.logger