kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Merge pull request #35565 from yahonda/rm_test_create_table_with_custom_sequence_name

Browse source 
Remove `MigrationTest#test_create_table_with_custom_sequence_name`
This commit is contained in:
Kasper Timm Hansen 2019-03-11 13:52:56 +01:00 committed by GitHub
commit b3e6d5fa36
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 33 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
activerecord/test/cases/migration_test.rb
View file

@ -567,39 +567,6 @@ class MigrationTest < ActiveRecord::TestCase
end
end
if current_adapter? :OracleAdapter
def test_create_table_with_custom_sequence_name
# table name is 29 chars, the standard sequence name will
# be 33 chars and should be shortened
assert_nothing_raised do
Person.connection.create_table :table_with_name_thats_just_ok do |t|
t.column :foo, :string, null: false
end
ensure
Person.connection.drop_table :table_with_name_thats_just_ok rescue nil
end
# should be all good w/ a custom sequence name
assert_nothing_raised do
Person.connection.create_table :table_with_name_thats_just_ok,
sequence_name: "suitably_short_seq" do |t|
t.column :foo, :string, null: false
end
Person.connection.execute("select suitably_short_seq.nextval from dual")
ensure
Person.connection.drop_table :table_with_name_thats_just_ok,
sequence_name: "suitably_short_seq" rescue nil
end
# confirm the custom sequence got dropped
assert_raise(ActiveRecord::StatementInvalid) do
Person.connection.execute("select suitably_short_seq.nextval from dual")
end
end
end
def test_decimal_scale_without_precision_should_raise
e = assert_raise(ArgumentError) do
Person.connection.create_table :test_decimal_scales, force: true do |t|