From b4ec9904c6f34331bbe32a304acf4b43e43a4f18 Mon Sep 17 00:00:00 2001 From: Michael Koziarski Date: Wed, 3 Oct 2007 05:31:36 +0000 Subject: [PATCH] Cache the descends_from_activerecord? call to speed up query generation. [skaes] Closes #9765 git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7723 5ecf4fe2-1ee6-0310-87b1-e25e094e27de --- activerecord/lib/active_record/base.rb | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/activerecord/lib/active_record/base.rb b/activerecord/lib/active_record/base.rb index 34685a78e1..df15457a9a 100755 --- a/activerecord/lib/active_record/base.rb +++ b/activerecord/lib/active_record/base.rb @@ -907,6 +907,11 @@ module ActiveRecord #:nodoc: end end + def finder_needs_type_condition? #:nodoc: + # This is like this because benchmarking justifies the strange :false stuff + :true == (@finder_needs_type_condition ||= descends_from_active_record? ? :false : :true) + end + # Returns a string like 'Post id:integer, title:string, body:text' def inspect if self == Base @@ -1199,9 +1204,9 @@ module ActiveRecord #:nodoc: segments = [] segments << sanitize_sql(scope[:conditions]) if scope && !scope[:conditions].blank? segments << sanitize_sql(conditions) unless conditions.blank? - segments << type_condition unless descends_from_active_record? - segments.compact! - sql << "WHERE (#{segments.join(") AND (")}) " unless segments.all?(&:blank?) + segments << type_condition if finder_needs_type_condition? + segments.delete_if{|s| s.blank?} + sql << "WHERE (#{segments.join(") AND (")}) " unless segments.empty? end def type_condition