kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Add missing spec and documentation for button_tag helper

Browse source
This commit is contained in:
Akshay Vishnoi 2015-05-20 02:14:51 +05:30
parent 6285fc17a9
commit b5ae29de03
2 changed files with 22 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
actionview/lib/action_view/helpers/form_tag_helper.rb
View file

@ -448,8 +448,9 @@ module ActionView
# <tt>reset</tt>button or a generic button which can be used in
# JavaScript, for example. You can use the button tag as a regular
# submit tag but it isn't supported in legacy browsers. However,
# the button tag allows richer labels such as images and emphasis,
# so this helper will also accept a block.
# the button tag does allow for richer labels such as images and emphasis,
# so this helper will also accept a block. By default, it will create
# a button tag with type `submit`, if type is not given.
#
# ==== Options
# * <tt>:data</tt> - This option can be used to add custom data attributes.
@ -472,6 +473,15 @@ module ActionView
# button_tag
# # => <button name="button" type="submit">Button</button>
#
# button_tag 'Reset', type: 'reset'
# # => <button name="button" type="reset">Reset</button>
#
# button_tag 'Button', type: 'button'
# # => <button name="button" type="button">Button</button>
#
# button_tag 'Reset', type: 'reset', disabled: true
# # => <button name="button" type="reset" disabled="disabled">Reset</button>
#
# button_tag(type: 'button') do
# content_tag(:strong, 'Ask me!')
# end
@ -479,6 +489,9 @@ module ActionView
# # <strong>Ask me!</strong>
# # </button>
#
# button_tag "Save", data: { confirm: "Are you sure?" }
# # => <button name="button" type="submit" data-confirm="Are you sure?">Save</button>
#
# button_tag "Checkout", data: { disable_with: "Please wait..." }
# # => <button data-disable-with="Please wait..." name="button" type="submit">Checkout</button>
#

7
actionview/test/template/form_tag_helper_test.rb
View file

@ -510,6 +510,13 @@ class FormTagHelperTest < ActionView::TestCase
)
end
def test_button_tag_with_data_disable_with_option
assert_dom_equal(
%(<button name="button" type="submit" data-disable-with="Please wait...">Checkout</button>),
button_tag("Checkout", data: { disable_with: "Please wait..." })
)
end
def test_image_submit_tag_with_confirmation
assert_dom_equal(
%(<input alt="Save" type="image" src="/images/save.gif" data-confirm="Are you sure?" />),