Merge pull request #29933 from kirs/frozen-actionpack

Use frozen string literal in actionpack/

.rubocop.yml

@@ -94,9 +94,12 @@ Style/FrozenStringLiteralComment:
     - 'activerecord/**/*'
     - 'actionmailer/**/*'
     - 'actionview/**/*'
+    - 'actionpack/**/*'
   Exclude:
     - 'actionview/test/**/*.builder'
     - 'actionview/test/**/*.ruby'
+    - 'actionpack/test/**/*.builder'
+    - 'actionpack/test/**/*.ruby'
 
 # Use `foo {}` not `foo{}`.
 Layout/SpaceBeforeBlockBraces:

actionpack/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rake/testtask"
 
 test_files = Dir.glob("test/**/*_test.rb")

actionpack/actionpack.gemspec

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 version = File.read(File.expand_path("../RAILS_VERSION", __dir__)).strip
 
 Gem::Specification.new do |s|

actionpack/bin/test

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 COMPONENT_ROOT = File.expand_path("..", __dir__)
 require_relative "../../tools/test"

actionpack/lib/abstract_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "action_pack"
 require "active_support/rails"
 require "active_support/i18n"

actionpack/lib/abstract_controller/asset_paths.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module AbstractController
   module AssetPaths #:nodoc:
     extend ActiveSupport::Concern

actionpack/lib/abstract_controller/base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "error"
 require "active_support/configurable"
 require "active_support/descendants_tracker"

actionpack/lib/abstract_controller/caching.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module AbstractController
   module Caching
     extend ActiveSupport::Concern

actionpack/lib/abstract_controller/caching/fragments.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module AbstractController
   module Caching
     # Fragment caching is used for caching various blocks within

actionpack/lib/abstract_controller/callbacks.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module AbstractController
   # = Abstract Controller Callbacks
   #

actionpack/lib/abstract_controller/collector.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "action_dispatch/http/mime_type"
 
 module AbstractController

actionpack/lib/abstract_controller/error.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module AbstractController
   class Error < StandardError #:nodoc:
   end

actionpack/lib/abstract_controller/helpers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support/dependencies"
 
 module AbstractController

actionpack/lib/abstract_controller/logger.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support/benchmarkable"
 
 module AbstractController

actionpack/lib/abstract_controller/railties/routes_helpers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module AbstractController
   module Railties
     module RoutesHelpers

actionpack/lib/abstract_controller/rendering.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "error"
 require "action_view"
 require "action_view/view_paths"

actionpack/lib/abstract_controller/translation.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module AbstractController
   module Translation
     # Delegates to <tt>I18n.translate</tt>. Also aliased as <tt>t</tt>.

actionpack/lib/abstract_controller/url_for.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module AbstractController
   # Includes +url_for+ into the host class (e.g. an abstract controller or mailer). The class
   # has to provide a +RouteSet+ by implementing the <tt>_routes</tt> methods. Otherwise, an

actionpack/lib/action_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support/rails"
 require "abstract_controller"
 require "action_dispatch"

actionpack/lib/action_controller/api.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "action_view"
 require "action_controller"
 require_relative "log_subscriber"

actionpack/lib/action_controller/api/api_rendering.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionController
   module ApiRendering
     extend ActiveSupport::Concern

actionpack/lib/action_controller/base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "action_view"
 require_relative "log_subscriber"
 require_relative "metal/params_wrapper"

actionpack/lib/action_controller/caching.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionController
   # \Caching is a cheap way of speeding up slow applications by keeping the result of
   # calculations, renderings, and database calls around for subsequent requests.

actionpack/lib/action_controller/form_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionController
   # Override the default form builder for all views rendered by this
   # controller and any of its descendants. Accepts a subclass of

actionpack/lib/action_controller/log_subscriber.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionController
   class LogSubscriber < ActiveSupport::LogSubscriber
     INTERNAL_PARAMS = %w(controller action format _method only_path)

actionpack/lib/action_controller/metal.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support/core_ext/array/extract_options"
 require "action_dispatch/middleware/stack"
 require "action_dispatch/http/request"

actionpack/lib/action_controller/metal/basic_implicit_render.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionController
   module BasicImplicitRender # :nodoc:
     def send_action(method, *args)

actionpack/lib/action_controller/metal/conditional_get.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support/core_ext/hash/keys"
 
 module ActionController

actionpack/lib/action_controller/metal/cookies.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionController #:nodoc:
   module Cookies
     extend ActiveSupport::Concern

actionpack/lib/action_controller/metal/data_streaming.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "exceptions"
 
 module ActionController #:nodoc:

actionpack/lib/action_controller/metal/etag_with_flash.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionController
   # When you're using the flash, it's generally used as a conditional on the view.
   # This means the content of the view depends on the flash. Which in turn means

actionpack/lib/action_controller/metal/etag_with_template_digest.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionController
   # When our views change, they should bubble up into HTTP cache freshness
   # and bust browser caches. So the template digest for the current action

actionpack/lib/action_controller/metal/exceptions.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionController
   class ActionControllerError < StandardError #:nodoc:
   end

actionpack/lib/action_controller/metal/flash.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionController #:nodoc:
   module Flash
     extend ActiveSupport::Concern

actionpack/lib/action_controller/metal/force_ssl.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support/core_ext/hash/except"
 require "active_support/core_ext/hash/slice"
 

actionpack/lib/action_controller/metal/head.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionController
   module Head
     # Returns a response that has no content (merely headers). The options

actionpack/lib/action_controller/metal/helpers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionController
   # The \Rails framework provides a large number of helpers for working with assets, dates, forms,
   # numbers and model objects, to name a few. These helpers are available to all templates

actionpack/lib/action_controller/metal/implicit_render.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionController
   # Handles implicit rendering for a controller action that does not
   # explicitly respond with +render+, +respond_to+, +redirect+, or +head+.

actionpack/lib/action_controller/metal/instrumentation.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "benchmark"
 require "abstract_controller/logger"
 

actionpack/lib/action_controller/metal/live.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "action_dispatch/http/response"
 require "delegate"
 require "active_support/json"
@@ -295,7 +297,7 @@ module ActionController
       return unless logger
 
       logger.fatal do
-        message = "\n#{exception.class} (#{exception.message}):\n"
+        message = "\n#{exception.class} (#{exception.message}):\n".dup
         message << exception.annoted_source_code.to_s if exception.respond_to?(:annoted_source_code)
         message << "  " << exception.backtrace.join("\n  ")
         "#{message}\n\n"

actionpack/lib/action_controller/metal/mime_responds.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "abstract_controller/collector"
 
 module ActionController #:nodoc:

actionpack/lib/action_controller/metal/parameter_encoding.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionController
   # Specify binary encoding for parameters for a given action.
   module ParameterEncoding

actionpack/lib/action_controller/metal/params_wrapper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support/core_ext/hash/slice"
 require "active_support/core_ext/hash/except"
 require "active_support/core_ext/module/anonymous"

actionpack/lib/action_controller/metal/redirecting.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionController
   module Redirecting
     extend ActiveSupport::Concern

actionpack/lib/action_controller/metal/renderers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "set"
 
 module ActionController

actionpack/lib/action_controller/metal/rendering.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support/core_ext/string/filters"
 
 module ActionController

actionpack/lib/action_controller/metal/request_forgery_protection.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rack/session/abstract/id"
 require_relative "exceptions"
 require "active_support/security_utils"

actionpack/lib/action_controller/metal/rescue.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionController #:nodoc:
   # This module is responsible for providing `rescue_from` helpers
   # to controllers and configuring when detailed exceptions must be

actionpack/lib/action_controller/metal/streaming.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rack/chunked"
 
 module ActionController #:nodoc:

actionpack/lib/action_controller/metal/strong_parameters.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support/core_ext/hash/indifferent_access"
 require "active_support/core_ext/hash/transform_values"
 require "active_support/core_ext/array/wrap"

actionpack/lib/action_controller/metal/testing.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionController
   module Testing
     extend ActiveSupport::Concern

actionpack/lib/action_controller/metal/url_for.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionController
   # Includes +url_for+ into the host class. The class has to provide a +RouteSet+ by implementing
   # the <tt>_routes</tt> method. Otherwise, an exception will be raised.

actionpack/lib/action_controller/railtie.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rails"
 require "action_controller"
 require "action_dispatch/railtie"

actionpack/lib/action_controller/railties/helpers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionController
   module Railties
     module Helpers

actionpack/lib/action_controller/renderer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support/core_ext/hash/keys"
 
 module ActionController

actionpack/lib/action_controller/template_assertions.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionController
   module TemplateAssertions
     def assert_template(options = {}, message = nil)

actionpack/lib/action_controller/test_case.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rack/session/abstract/id"
 require "active_support/core_ext/hash/conversions"
 require "active_support/core_ext/object/to_query"

actionpack/lib/action_dispatch.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #--
 # Copyright (c) 2004-2017 David Heinemeier Hansson
 #

actionpack/lib/action_dispatch/http/cache.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionDispatch
   module Http
     module Cache

actionpack/lib/action_dispatch/http/filter_parameters.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "parameter_filter"
 
 module ActionDispatch

actionpack/lib/action_dispatch/http/filter_redirect.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionDispatch
   module Http
     module FilterRedirect

actionpack/lib/action_dispatch/http/headers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionDispatch
   module Http
     # Provides access to the request's HTTP headers from the environment.

actionpack/lib/action_dispatch/http/mime_negotiation.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support/core_ext/module/attribute_accessors"
 
 module ActionDispatch

actionpack/lib/action_dispatch/http/mime_type.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # -*- frozen-string-literal: true -*-
 
 require "singleton"

actionpack/lib/action_dispatch/http/mime_types.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Build list of Mime types for HTTP responses
 # http://www.iana.org/assignments/media-types/
 

actionpack/lib/action_dispatch/http/parameter_filter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support/core_ext/object/duplicable"
 
 module ActionDispatch

actionpack/lib/action_dispatch/http/parameters.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionDispatch
   module Http
     module Parameters

actionpack/lib/action_dispatch/http/rack_cache.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rack/cache"
 require "rack/cache/context"
 require "active_support/cache"

actionpack/lib/action_dispatch/http/response.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support/core_ext/module/attribute_accessors"
 require_relative "filter_redirect"
 require_relative "cache"

actionpack/lib/action_dispatch/http/upload.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionDispatch
   module Http
     # Models uploaded files.

actionpack/lib/action_dispatch/journey.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "journey/router"
 require_relative "journey/gtg/builder"
 require_relative "journey/gtg/simulator"

actionpack/lib/action_dispatch/journey/gtg/builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "transition_table"
 
 module ActionDispatch

actionpack/lib/action_dispatch/journey/gtg/simulator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "strscan"
 
 module ActionDispatch

actionpack/lib/action_dispatch/journey/gtg/transition_table.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "../nfa/dot"
 
 module ActionDispatch

actionpack/lib/action_dispatch/journey/nfa/builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "transition_table"
 require_relative "../gtg/transition_table"
 

actionpack/lib/action_dispatch/journey/nfa/dot.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionDispatch
   module Journey # :nodoc:
     module NFA # :nodoc:

actionpack/lib/action_dispatch/journey/nfa/simulator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "strscan"
 
 module ActionDispatch

actionpack/lib/action_dispatch/journey/nfa/transition_table.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "dot"
 
 module ActionDispatch

actionpack/lib/action_dispatch/journey/nodes/node.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "../visitors"
 
 module ActionDispatch

actionpack/lib/action_dispatch/journey/parser_extras.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "scanner"
 require_relative "nodes/node"
 

actionpack/lib/action_dispatch/journey/path/pattern.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionDispatch
   module Journey # :nodoc:
     module Path # :nodoc:

actionpack/lib/action_dispatch/journey/route.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionDispatch
   # :stopdoc:
   module Journey

actionpack/lib/action_dispatch/journey/router.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "router/utils"
 require_relative "routes"
 require_relative "formatter"

actionpack/lib/action_dispatch/journey/router/utils.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionDispatch
   module Journey # :nodoc:
     class Router # :nodoc:
@@ -13,7 +15,7 @@ module ActionDispatch
         #   normalize_path("")      # => "/"
         #   normalize_path("/%ab")  # => "/%AB"
         def self.normalize_path(path)
-          path ||= ''
+          path ||= ""
           encoding = path.encoding
           path = "/#{path}".dup
           path.squeeze!("/".freeze)

actionpack/lib/action_dispatch/journey/routes.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionDispatch
   module Journey # :nodoc:
     # The Routing table. Contains all routes for a system. Routes can be

actionpack/lib/action_dispatch/middleware/callbacks.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionDispatch
   # Provides callbacks to be executed before and after dispatching the request.
   class Callbacks

actionpack/lib/action_dispatch/middleware/cookies.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support/core_ext/hash/keys"
 require "active_support/key_generator"
 require "active_support/message_verifier"

actionpack/lib/action_dispatch/middleware/debug_locks.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionDispatch
   # This middleware can be used to diagnose deadlocks in the autoload interlock.
   #

actionpack/lib/action_dispatch/middleware/exception_wrapper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support/core_ext/module/attribute_accessors"
 require "rack/utils"
 

actionpack/lib/action_dispatch/middleware/executor.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rack/body_proxy"
 
 module ActionDispatch

actionpack/lib/action_dispatch/middleware/flash.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support/core_ext/hash/keys"
 
 module ActionDispatch

actionpack/lib/action_dispatch/middleware/public_exceptions.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionDispatch
   # When called, this middleware renders an error page. By default if an HTML
   # response is expected it will render static error pages from the `/public`

actionpack/lib/action_dispatch/middleware/reloader.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActionDispatch
   # ActionDispatch::Reloader wraps the request with callbacks provided by ActiveSupport::Reloader
   # callbacks, intended to assist with code reloading during development.

actionpack/lib/action_dispatch/middleware/remote_ip.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "ipaddr"
 
 module ActionDispatch

actionpack/lib/action_dispatch/middleware/request_id.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "securerandom"
 require "active_support/core_ext/string/access"
 

actionpack/lib/action_dispatch/middleware/session/abstract_store.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rack/utils"
 require "rack/request"
 require "rack/session/abstract/id"

actionpack/lib/action_dispatch/middleware/session/cache_store.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "abstract_store"
 
 module ActionDispatch

actionpack/lib/action_dispatch/middleware/session/cookie_store.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support/core_ext/hash/keys"
 require_relative "abstract_store"
 require "rack/session/cookie"

actionpack/lib/action_dispatch/middleware/session/mem_cache_store.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "abstract_store"
 begin
   require "rack/session/dalli"

actionpack/lib/action_dispatch/middleware/show_exceptions.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "../http/request"
 require_relative "exception_wrapper"