1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00

Use plain assert in assert_changes to avoid MT6 refutes

Seeing the previously issued PRs about it, we can avoid the `nil`
comparisons that can happen in `assert_changes` by using plain `assert`
calls.

This is to avoid a deprecation warning about comparing `nil` values in
`assert_equal` for Minitest 5 and a crash in Minitest 6.

You can see the preparations done in [`assert_equal`][ae]. You can also
see that [`assert`][a] does not care about `nil`s.

[ae]: ca6a71ca90/lib/minitest/assertions.rb (L159-L188)
[a]: ca6a71ca90/lib/minitest/assertions.rb (L131-L142)
This commit is contained in:
Genadi Samokovarov 2017-11-07 10:28:19 +02:00
parent 204b22fa1c
commit bbe437faec
2 changed files with 5 additions and 9 deletions

View file

@ -159,7 +159,7 @@ module ActiveSupport
if to == UNTRACKED
error = "#{expression.inspect} didn't change"
error = "#{message}.\n#{error}" if message
assert_not_equal before, after, error
assert before != after, error
else
error = "#{expression.inspect} didn't change to #{to}"
error = "#{message}.\n#{error}" if message
@ -190,12 +190,7 @@ module ActiveSupport
error = "#{expression.inspect} did change to #{after}"
error = "#{message}.\n#{error}" if message
if before.nil?
assert_nil after, error
else
assert_equal before, after, error
end
assert before == after, error
retval
end

View file

@ -179,6 +179,7 @@ class AssertDifferenceTest < ActiveSupport::TestCase
end
def test_assert_changes_works_with_any_object
# Silences: instance variable @new_object not initialized.
retval = silence_warnings do
assert_changes :@new_object, from: nil, to: 42 do
@new_object = 42
@ -201,7 +202,7 @@ class AssertDifferenceTest < ActiveSupport::TestCase
def test_assert_changes_with_to_and_case_operator
token = nil
assert_changes -> { token }, to: /\w{32}/ do
assert_changes -> { token }, to: /\w{32}/ do
token = SecureRandom.hex
end
end
@ -236,7 +237,7 @@ class AssertDifferenceTest < ActiveSupport::TestCase
end
end
assert_equal "@object.num should not change.\n\"@object.num\" did change to 1.\nExpected: 0\n Actual: 1", error.message
assert_equal "@object.num should not change.\n\"@object.num\" did change to 1", error.message
end
end