kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Revert "test runner should crash with non existing file argument."

Browse source 
This reverts commit 465f0fbca3.

This breaks some cases where non file / directory arguments are passed
to the runner (for example db:migrate).

I still think that we can get this to work. From what I can tell there
is no reason why db:migrate is passed along to `Minitest.run`. I'll
revert and investigate possible solutions.
This commit is contained in:
Yves Senn 2015-08-03 13:42:30 +02:00
parent 63c03077f3
commit bc3956c0d5
2 changed files with 1 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
railties/lib/rails/test_unit/test_requirer.rb
View file

@ -18,7 +18,7 @@ module Rails
arg = arg.gsub(/:(\d+)?$/, '') arg = arg.gsub(/:(\d+)?$/, '')
if Dir.exist?(arg) if Dir.exist?(arg)
"#{arg}/**/*_test.rb" "#{arg}/**/*_test.rb"
else elsif File.file?(arg)
arg arg
end end
end end

5
railties/test/application/test_runner_test.rb
View file

@ -307,11 +307,6 @@ module ApplicationTests
end end
end end
def test_crash_with_non_existing_file_or_dirname
error = capture(:stderr) { run_test_command('test/nope/niet_test.rb') }
assert_match(%r{cannot load such file.+test/nope/niet_test.rb}, error)
end
def test_shows_filtered_backtrace_by_default def test_shows_filtered_backtrace_by_default
create_backtrace_test create_backtrace_test