kotovalexarian-likes-github
/
rails--rails
mirror of https://github.com/rails/rails.git
1
0
Fork 0
Code Releases Activity

Merge pull request #41754 from jhawthorn/branch_memoize_polymorphic 

Simplify and memoize Preloader::Branch#polymorphic?
This commit is contained in:
Rafael França 2021-03-24 16:12:24 -04:00 committed by GitHub
parent 2eb5458978 df15d36970
commit bcf3752247
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
activerecord/lib/active_record/associations/preloader/branch.rb
View File

@ -39,9 +39,10 @@ module ActiveRecord
def grouped_records
h = {}
polymorphic_parent = !root? && parent.polymorphic?
source_records.each do |record|
reflection = record.class._reflect_on_association(association)
next if polymorphic_parent? && !reflection || !record.association(association).klass
next if polymorphic_parent && !reflection || !record.association(association).klass
(h[reflection] ||= []) << record
end
h
@ -53,17 +54,13 @@ module ActiveRecord
end
end
def polymorphic_parent?
return false if root?
parent.polymorphic?
end
def polymorphic?
return false if root?
return @polymorphic if defined?(@polymorphic)
grouped_records.keys.any? do |reflection|
reflection.options[:polymorphic]
@polymorphic = source_records.any? do |record|
reflection = record.class._reflect_on_association(association)
reflection && reflection.options[:polymorphic]
end
end