kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

allow options to be passed to email address auto generation

Browse source 
Signed-off-by: Michael Koziarski <michael@koziarski.com>

[#1418 state:committed]
This commit is contained in:
Andrew Kaspick 2008-11-19 12:55:27 -06:00 committed by Michael Koziarski
parent 25f6524b89
commit bda55f82c6
2 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
actionpack/lib/action_view/helpers/text_helper.rb
View file

@ -370,8 +370,8 @@ module ActionView
options.reverse_merge!(:link => :all, :html => {}) options.reverse_merge!(:link => :all, :html => {})
case options[:link].to_sym case options[:link].to_sym
when :all then auto_link_email_addresses(auto_link_urls(text, options[:html], &block), &block) when :all then auto_link_email_addresses(auto_link_urls(text, options[:html], &block), options[:html], &block)
when :email_addresses then auto_link_email_addresses(text, &block) when :email_addresses then auto_link_email_addresses(text, options[:html], &block)
when :urls then auto_link_urls(text, options[:html], &block) when :urls then auto_link_urls(text, options[:html], &block)
end end
end end
@ -559,7 +559,7 @@ module ActionView
# Turns all email addresses into clickable links. If a block is given, # Turns all email addresses into clickable links. If a block is given,
# each email is yielded and the result is used as the link text. # each email is yielded and the result is used as the link text.
def auto_link_email_addresses(text) def auto_link_email_addresses(text, html_options = {})
body = text.dup body = text.dup
text.gsub(/([\w\.!#\$%\-+.]+@[A-Za-z0-9\-]+(\.[A-Za-z0-9\-]+)+)/) do text.gsub(/([\w\.!#\$%\-+.]+@[A-Za-z0-9\-]+(\.[A-Za-z0-9\-]+)+)/) do
text = $1 text = $1
@ -568,7 +568,7 @@ module ActionView
text text
else else
display_text = (block_given?) ? yield(text) : text display_text = (block_given?) ? yield(text) : text
%{<a href="mailto:#{text}">#{display_text}</a>} mail_to text, display_text, html_options
end end
end end
end end

7
actionpack/test/template/text_helper_test.rb
View file

@ -262,6 +262,11 @@ class TextHelperTest < ActionView::TestCase
email2_result = %{<a href="mailto:#{email2_raw}">#{email2_raw}</a>} email2_result = %{<a href="mailto:#{email2_raw}">#{email2_raw}</a>}
assert_equal email2_result, auto_link(email2_raw) assert_equal email2_result, auto_link(email2_raw)
email3_raw = '+david@loudthinking.com'
email3_result = %{<a href="&#109;&#97;&#105;&#108;&#116;&#111;&#58;+%64%61%76%69%64@%6c%6f%75%64%74%68%69%6e%6b%69%6e%67.%63%6f%6d">#{email3_raw}</a>}
assert_equal email3_result, auto_link(email3_raw, :all, :encode => :hex)
assert_equal email3_result, auto_link(email3_raw, :email_addresses, :encode => :hex)
link2_raw = 'www.rubyonrails.com' link2_raw = 'www.rubyonrails.com'
link2_result = generate_result(link2_raw, "http://#{link2_raw}") link2_result = generate_result(link2_raw, "http://#{link2_raw}")
assert_equal %(Go to #{link2_result}), auto_link("Go to #{link2_raw}", :urls) assert_equal %(Go to #{link2_result}), auto_link("Go to #{link2_raw}", :urls)
@ -362,7 +367,7 @@ class TextHelperTest < ActionView::TestCase
end end
def test_auto_link_with_options_hash def test_auto_link_with_options_hash
assert_dom_equal 'Welcome to my new blog at <a href="http://www.myblog.com/" class="menu" target="_blank">http://www.myblog.com/</a>. Please e-mail me at <a href="mailto:me@email.com">me@email.com</a>.', assert_dom_equal 'Welcome to my new blog at <a href="http://www.myblog.com/" class="menu" target="_blank">http://www.myblog.com/</a>. Please e-mail me at <a href="mailto:me@email.com" class="menu" target="_blank">me@email.com</a>.',
auto_link("Welcome to my new blog at http://www.myblog.com/. Please e-mail me at me@email.com.", auto_link("Welcome to my new blog at http://www.myblog.com/. Please e-mail me at me@email.com.",
:link => :all, :html => { :class => "menu", :target => "_blank" }) :link => :all, :html => { :class => "menu", :target => "_blank" })
end end