kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Updated ActionDispatch::Request.remote_ip=

Browse source 
Updated the setter to clear the value in the `@remote_ip` instance
variable before setting the header that the value is derived from in the
getter.
This commit is contained in:
norm 2019-10-06 14:28:43 -07:00
parent a4ea17f6b6
commit bf14a8e235
3 changed files with 14 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
actionpack/CHANGELOG.md
View file

@ -1,3 +1,11 @@
* Updated `ActionDispatch::Request.remote_ip` setter to clear set the instance
`remote_ip` to `nil` before setting the header that the value is derived
from.
Fixes https://github.com/rails/rails/issues/37383
*Norm Provost*
* `ActionController::Base.log_at` allows setting a different log level per request.
```ruby

1
actionpack/lib/action_dispatch/http/request.rb
View file

@ -281,6 +281,7 @@ module ActionDispatch
end
def remote_ip=(remote_ip)
@remote_ip = nil
set_header "action_dispatch.remote_ip", remote_ip
end

5
actionpack/test/dispatch/request_test.rb
View file

@ -103,6 +103,11 @@ class RequestIP < BaseRequestTest
request = stub_request "HTTP_X_FORWARDED_FOR" => "not_ip_address"
assert_nil request.remote_ip
request = stub_request "REMOTE_ADDR" => "1.2.3.4"
assert_equal "1.2.3.4", request.remote_ip
request.remote_ip = "2.3.4.5"
assert_equal "2.3.4.5", request.remote_ip
end
test "remote ip spoof detection" do