kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Don't give up statement cache just because of there is one composed_of

Browse source 
It is too pessimistic, we can check the attribute whether aggregated or
not by `reflect_on_aggregation`.
This commit is contained in:
Ryuta Kamizono 2020-06-05 12:14:15 +09:00
parent dbda5febe4
commit c2dc793e59
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
activerecord/lib/active_record/core.rb
View file

@ -196,7 +196,7 @@ module ActiveRecord
end
def find_by(*args) # :nodoc:
return super if scope_attributes? || reflect_on_all_aggregations.any? ||
return super if scope_attributes? ||
columns_hash.key?(inheritance_column) && !base_class?
hash = args.first
@ -210,6 +210,8 @@ module ActiveRecord
reflection = _reflect_on_association(name)
if reflection&.belongs_to? && !reflection.polymorphic?
reflection.join_foreign_key
elsif reflect_on_aggregation(name)
return super
else
name
end