mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
Fix failing test using custom file watcher
LoadingTest#test_does_not_reload_constants_on_development_if_custom_file_watcher_always_returns_false in railties/test/application/loading_test.rb is failing with: `NoMethodError: undefined method 'execute' for #<#<Class:0x00000002465a30>:0x00000001f79698>` The test creates an anonymous class to be used as a custom file watcher using `config.file_watcher=`. Per the Rails guides for Configuring, the class set to `config.file_watcher` “Must conform to ActiveSupport::FileUpdateChecker API”. Per the docs for ActiveSupport::FileUpdateChecker, the API depends on four methods: #initialize, #updated?, #execute, and #execute_if_updated. The custom file watcher in the failing test only implements the first two methods. This pull request adds #execute and #execute_if_updated to the custom file_watcher, conforming it to the ActiveSupport::FileUpdateChecker API, and passing the test.
This commit is contained in:
parent
72b92e8172
commit
c3668c3950
1 changed files with 2 additions and 0 deletions
|
@ -169,6 +169,8 @@ class LoadingTest < ActiveSupport::TestCase
|
|||
config.file_watcher = Class.new do
|
||||
def initialize(*); end
|
||||
def updated?; false; end
|
||||
def execute; end
|
||||
def execute_if_updated; false; end
|
||||
end
|
||||
RUBY
|
||||
|
||||
|
|
Loading…
Reference in a new issue