kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

fix rubocop errors

Browse source 
Using `bundle exec rubocop -a` and visually verified
This commit is contained in:
Hartley McGuire 2022-03-08 15:36:24 -05:00
parent 9b76e93fea
commit c3844a9dc0
3 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
activestorage/lib/active_storage/transformers/image_processing_transformer.rb
View file

@ -340,7 +340,7 @@ module ActiveStorage
end end
def validate_transformation(name, argument) def validate_transformation(name, argument)
method_name = name.to_s.gsub("-","_") method_name = name.to_s.tr("-", "_")
unless SUPPORTED_IMAGE_PROCESSING_METHODS.any? { |method| method_name == method } unless SUPPORTED_IMAGE_PROCESSING_METHODS.any? { |method| method_name == method }
raise UnsupportedImageProcessingMethod, <<~ERROR.squish raise UnsupportedImageProcessingMethod, <<~ERROR.squish

8
activestorage/test/models/variant_test.rb
View file

@ -237,7 +237,7 @@ class ActiveStorage::VariantTest < ActiveSupport::TestCase
end end
assert_raise(ActiveStorage::Transformers::ImageProcessingTransformer::UnsupportedImageProcessingArgument) do assert_raise(ActiveStorage::Transformers::ImageProcessingTransformer::UnsupportedImageProcessingArgument) do
blob.variant(resize: [123, {"-write /tmp/file.erb": "something"}, "/tmp/file.erb"]).processed blob.variant(resize: [123, { "-write /tmp/file.erb": "something" }, "/tmp/file.erb"]).processed
end end
end end
end end
@ -246,7 +246,7 @@ class ActiveStorage::VariantTest < ActiveSupport::TestCase
process_variants_with :mini_magick do process_variants_with :mini_magick do
blob = create_file_blob(filename: "racecar.jpg") blob = create_file_blob(filename: "racecar.jpg")
assert_raise(ActiveStorage::Transformers::ImageProcessingTransformer::UnsupportedImageProcessingArgument) do assert_raise(ActiveStorage::Transformers::ImageProcessingTransformer::UnsupportedImageProcessingArgument) do
blob.variant(saver: {"-write": "/tmp/file.erb"}).processed blob.variant(saver: { "-write": "/tmp/file.erb" }).processed
end end
end end
end end
@ -255,11 +255,11 @@ class ActiveStorage::VariantTest < ActiveSupport::TestCase
process_variants_with :mini_magick do process_variants_with :mini_magick do
blob = create_file_blob(filename: "racecar.jpg") blob = create_file_blob(filename: "racecar.jpg")
assert_raise(ActiveStorage::Transformers::ImageProcessingTransformer::UnsupportedImageProcessingArgument) do assert_raise(ActiveStorage::Transformers::ImageProcessingTransformer::UnsupportedImageProcessingArgument) do
blob.variant(saver: {"something": {"-write": "/tmp/file.erb"}}).processed blob.variant(saver: { "something": { "-write": "/tmp/file.erb" } }).processed
end end
assert_raise(ActiveStorage::Transformers::ImageProcessingTransformer::UnsupportedImageProcessingArgument) do assert_raise(ActiveStorage::Transformers::ImageProcessingTransformer::UnsupportedImageProcessingArgument) do
blob.variant(saver: {"something": ["-write", "/tmp/file.erb"]}).processed blob.variant(saver: { "something": ["-write", "/tmp/file.erb"] }).processed
end end
end end
end end

2
railties/test/application/configuration_test.rb
View file

@ -3136,7 +3136,7 @@ module ApplicationTests
app "development" app "development"
assert ActiveStorage.unsupported_image_processing_arguments.include?("-danger") assert ActiveStorage.unsupported_image_processing_arguments.include?("-danger")
refute ActiveStorage.unsupported_image_processing_arguments.include?("-set") assert_not ActiveStorage.unsupported_image_processing_arguments.include?("-set")
end end
test "hosts include .localhost in development" do test "hosts include .localhost in development" do