Merge pull request #30079 from kamipo/move_test_not_compatible_with_serialize_macro

Move `test_not_compatible_with_serialize_macro` to `JSONSharedTestCases`
This commit is contained in:
Matthew Draper 2017-08-13 20:16:41 +09:30 committed by GitHub
commit c8c2029041
2 changed files with 11 additions and 11 deletions

View File

@ -21,8 +21,8 @@ module PostgresqlJSONSharedTestCases
@connection.add_column "json_data_type", "permissions", column_type, default: { "users": "read", "posts": ["read", "write"] }
klass.reset_column_information
assert_equal({ "users" => "read", "posts" => ["read", "write"] }, JsonDataType.column_defaults["permissions"])
assert_equal({ "users" => "read", "posts" => ["read", "write"] }, JsonDataType.new.permissions)
assert_equal({ "users" => "read", "posts" => ["read", "write"] }, klass.column_defaults["permissions"])
assert_equal({ "users" => "read", "posts" => ["read", "write"] }, klass.new.permissions)
end
def test_deserialize_with_array
@ -33,15 +33,6 @@ module PostgresqlJSONSharedTestCases
x.reload
assert_equal ["foo" => "bar"], x.objects
end
def test_not_compatible_with_serialize_macro
new_klass = Class.new(klass) do
serialize :payload, JSON
end
assert_raises(ActiveRecord::AttributeMethods::Serialization::ColumnNotSerializableError) do
new_klass.new
end
end
end
class PostgresqlJSONTest < ActiveRecord::PostgreSQLTestCase

View File

@ -216,6 +216,15 @@ module JSONSharedTestCases
assert_equal true, json.payload
end
def test_not_compatible_with_serialize_macro
new_klass = Class.new(klass) do
serialize :payload, JSON
end
assert_raises(ActiveRecord::AttributeMethods::Serialization::ColumnNotSerializableError) do
new_klass.new
end
end
private
def klass
JsonDataType