kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Improve migration/column_attributes_test.rb (#25286)

Browse source 
* Test `test_unabstracted_database_dependent_types` for `PostgreSQLAdapter`
* Add `test_change_column_with_new_precision_and_scale` for `SQLite3Adapter`
 * This test case and comment was lost at 28bb02a78f
This commit is contained in:
Ryuta Kamizono 2017-08-18 17:52:33 +09:00 committed by GitHub
parent 53524818bf
commit c910fd82dc
1 changed files with 17 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
activerecord/test/cases/migration/column_attributes_test.rb
View file

@ -45,11 +45,11 @@ module ActiveRecord
assert_nil TestModel.columns_hash["description"].limit assert_nil TestModel.columns_hash["description"].limit
end end
if current_adapter?(:Mysql2Adapter) if current_adapter?(:Mysql2Adapter, :PostgreSQLAdapter)
def test_unabstracted_database_dependent_types def test_unabstracted_database_dependent_types
add_column :test_models, :intelligence_quotient, :tinyint add_column :test_models, :intelligence_quotient, :smallint
TestModel.reset_column_information TestModel.reset_column_information
assert_match(/tinyint/, TestModel.columns_hash["intelligence_quotient"].sql_type) assert_match(/smallint/, TestModel.columns_hash["intelligence_quotient"].sql_type)
end end
end end
@ -99,7 +99,21 @@ module ActiveRecord
assert_equal 7, wealth_column.scale assert_equal 7, wealth_column.scale
end end
# Test SQLite3 adapter specifically for decimal types with precision and scale
# attributes, since these need to be maintained in schema but aren't actually
# used in SQLite3 itself
if current_adapter?(:SQLite3Adapter) if current_adapter?(:SQLite3Adapter)
def test_change_column_with_new_precision_and_scale
connection.add_column "test_models", "wealth", :decimal, precision: 9, scale: 7
connection.change_column "test_models", "wealth", :decimal, precision: 12, scale: 8
TestModel.reset_column_information
wealth_column = TestModel.columns_hash["wealth"]
assert_equal 12, wealth_column.precision
assert_equal 8, wealth_column.scale
end
def test_change_column_preserve_other_column_precision_and_scale def test_change_column_preserve_other_column_precision_and_scale
connection.add_column "test_models", "last_name", :string connection.add_column "test_models", "last_name", :string
connection.add_column "test_models", "wealth", :decimal, precision: 9, scale: 7 connection.add_column "test_models", "wealth", :decimal, precision: 9, scale: 7