kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Merge pull request #12038 from SamSaffron/memoize_decorate_cols

Browse source 
Perf: memoize serialized column list and time zone column list
This commit is contained in:
Rafael Mendonça França 2013-08-26 17:46:56 -07:00
commit cad50d2cff
1 changed files with 27 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

44
activerecord/lib/active_record/model_schema.rb
View file

@ -224,13 +224,20 @@ module ActiveRecord
def decorate_columns(columns_hash) # :nodoc:
return if columns_hash.empty?
columns_hash.each do |name, col|
if serialized_attributes.key?(name)
columns_hash[name] = AttributeMethods::Serialization::Type.new(col)
end
if create_time_zone_conversion_attribute?(name, col)
columns_hash[name] = AttributeMethods::TimeZoneConversion::Type.new(col)
end
@serialized_column_names ||= self.columns_hash.keys.find_all do |name|
serialized_attributes.key?(name)
end
@serialized_column_names.each do |name|
columns_hash[name] = AttributeMethods::Serialization::Type.new(columns_hash[name])
end
@time_zone_column_names ||= self.columns_hash.find_all do |name, col|
create_time_zone_conversion_attribute?(name, col)
end.map!(&:first)
@time_zone_column_names.each do |name|
columns_hash[name] = AttributeMethods::TimeZoneConversion::Type.new(columns_hash[name])
end
columns_hash
@ -284,16 +291,19 @@ module ActiveRecord
undefine_attribute_methods
connection.schema_cache.clear_table_cache!(table_name) if table_exists?
@arel_engine = nil
@column_defaults = nil
@column_names = nil
@columns = nil
@columns_hash = nil
@column_types = nil
@content_columns = nil
@dynamic_methods_hash = nil
@inheritance_column = nil unless defined?(@explicit_inheritance_column) && @explicit_inheritance_column
@relation = nil
@arel_engine = nil
@column_defaults = nil
@column_names = nil
@columns = nil
@columns_hash = nil
@column_types = nil
@content_columns = nil
@dynamic_methods_hash = nil
@inheritance_column = nil unless defined?(@explicit_inheritance_column) && @explicit_inheritance_column
@relation = nil
@serialized_column_names = nil
@time_zone_column_names = nil
@cached_time_zone = nil
end
# This is a hook for use by modules that need to do extra stuff to