mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
Fix brittle query string comparisons
This commit is contained in:
parent
e900a8437a
commit
cc0103fe83
1 changed files with 5 additions and 5 deletions
|
@ -321,8 +321,8 @@ class UrlWriterTests < ActionController::TestCase
|
|||
params = extract_params(url)
|
||||
assert_equal params[0], { 'query[hobby]' => 'piercing' }.to_query
|
||||
assert_equal params[1], { 'query[person][name]' => 'Bob' }.to_query
|
||||
assert_equal params[2], { 'query[person][position][]' => 'prof' }.to_query
|
||||
assert_equal params[3], { 'query[person][position][]' => 'art director' }.to_query
|
||||
assert_equal params[2], { 'query[person][position][]' => 'art director' }.to_query
|
||||
assert_equal params[3], { 'query[person][position][]' => 'prof' }.to_query
|
||||
end
|
||||
|
||||
def test_path_generation_for_symbol_parameter_keys
|
||||
|
@ -359,10 +359,10 @@ class UrlWriterTests < ActionController::TestCase
|
|||
controller = kls.new
|
||||
params = {:id => 1, :format => :xml}
|
||||
assert_deprecated do
|
||||
assert_equal("/posts/1.xml", controller.send(:formatted_post_path, params))
|
||||
assert_equal("/posts/1.xml", controller.send(:formatted_post_path, params))
|
||||
end
|
||||
assert_deprecated do
|
||||
assert_equal("/posts/1.xml", controller.send(:formatted_post_path, 1, :xml))
|
||||
assert_equal("/posts/1.xml", controller.send(:formatted_post_path, 1, :xml))
|
||||
end
|
||||
end
|
||||
end
|
||||
|
@ -382,6 +382,6 @@ class UrlWriterTests < ActionController::TestCase
|
|||
|
||||
private
|
||||
def extract_params(url)
|
||||
url.split('?', 2).last.split('&')
|
||||
url.split('?', 2).last.split('&').sort
|
||||
end
|
||||
end
|
||||
|
|
Loading…
Reference in a new issue