From cfb0babec348a5543ae4c4a8c2c5e4438644429e Mon Sep 17 00:00:00 2001 From: David Heinemeier Hansson Date: Sat, 24 Dec 2005 22:58:33 +0000 Subject: [PATCH] Added :select option for JavaScriptMacroHelper#auto_complete_field that makes it easier to only use part of the auto-complete suggestion as the value for insertion [Thomas Fuchs] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3348 5ecf4fe2-1ee6-0310-87b1-e25e094e27de --- .../helpers/javascripts/controls.js | 3 +- .../helpers/javascripts/effects.js | 3 +- railties/html/javascripts/controls.js | 8 ++++- railties/html/javascripts/effects.js | 29 +++++++++---------- 4 files changed, 25 insertions(+), 18 deletions(-) diff --git a/actionpack/lib/action_view/helpers/javascripts/controls.js b/actionpack/lib/action_view/helpers/javascripts/controls.js index f13733d5f0..a8e7ec7452 100644 --- a/actionpack/lib/action_view/helpers/javascripts/controls.js +++ b/actionpack/lib/action_view/helpers/javascripts/controls.js @@ -221,13 +221,14 @@ Autocompleter.Base.prototype = { this.options.updateElement(selectedElement); return; } + var value = ''; if (this.options.select) { var nodes = document.getElementsByClassName(this.options.select, selectedElement) || []; if(nodes.length>0) value = Element.collectTextNodes(nodes[0], this.options.select); } else value = Element.collectTextNodesIgnoreClass(selectedElement, 'informal'); - + var lastTokenPos = this.findLastToken(); if (lastTokenPos != -1) { var newValue = this.element.value.substr(0, lastTokenPos + 1); diff --git a/actionpack/lib/action_view/helpers/javascripts/effects.js b/actionpack/lib/action_view/helpers/javascripts/effects.js index ebca0c490a..035a63e62f 100644 --- a/actionpack/lib/action_view/helpers/javascripts/effects.js +++ b/actionpack/lib/action_view/helpers/javascripts/effects.js @@ -22,7 +22,7 @@ String.prototype.parseColor = function() { } } return(color.length==7 ? color : (arguments[0] || this)); -} +} Element.collectTextNodes = function(element) { return $A($(element).childNodes).collect( function(node) { @@ -39,6 +39,7 @@ Element.collectTextNodesIgnoreClass = function(element, className) { }).flatten().join(''); } + Element.setStyle = function(element, style) { element = $(element); for(k in style) element.style[k.camelize()] = style[k]; diff --git a/railties/html/javascripts/controls.js b/railties/html/javascripts/controls.js index 9742b69188..a8e7ec7452 100644 --- a/railties/html/javascripts/controls.js +++ b/railties/html/javascripts/controls.js @@ -222,7 +222,13 @@ Autocompleter.Base.prototype = { return; } - var value = Element.collectTextNodesIgnoreClass(selectedElement, 'informal'); + var value = ''; + if (this.options.select) { + var nodes = document.getElementsByClassName(this.options.select, selectedElement) || []; + if(nodes.length>0) value = Element.collectTextNodes(nodes[0], this.options.select); + } else + value = Element.collectTextNodesIgnoreClass(selectedElement, 'informal'); + var lastTokenPos = this.findLastToken(); if (lastTokenPos != -1) { var newValue = this.element.value.substr(0, lastTokenPos + 1); diff --git a/railties/html/javascripts/effects.js b/railties/html/javascripts/effects.js index 414398ce47..035a63e62f 100644 --- a/railties/html/javascripts/effects.js +++ b/railties/html/javascripts/effects.js @@ -24,23 +24,22 @@ String.prototype.parseColor = function() { return(color.length==7 ? color : (arguments[0] || this)); } -Element.collectTextNodesIgnoreClass = function(element, ignoreclass) { - var children = $(element).childNodes; - var text = ''; - var classtest = new RegExp('^([^ ]+ )*' + ignoreclass+ '( [^ ]+)*$','i'); - - for (var i = 0; i < children.length; i++) { - if(children[i].nodeType==3) { - text+=children[i].nodeValue; - } else { - if((!children[i].className.match(classtest)) && children[i].hasChildNodes()) - text += Element.collectTextNodesIgnoreClass(children[i], ignoreclass); - } - } - - return text; +Element.collectTextNodes = function(element) { + return $A($(element).childNodes).collect( function(node) { + return (node.nodeType==3 ? node.nodeValue : + (node.hasChildNodes() ? Element.collectTextNodes(node) : '')); + }).flatten().join(''); } +Element.collectTextNodesIgnoreClass = function(element, className) { + return $A($(element).childNodes).collect( function(node) { + return (node.nodeType==3 ? node.nodeValue : + ((node.hasChildNodes() && !Element.hasClassName(node,className)) ? + Element.collectTextNodes(node) : '')); + }).flatten().join(''); +} + + Element.setStyle = function(element, style) { element = $(element); for(k in style) element.style[k.camelize()] = style[k];