kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Module#{attr,attr_accessor,attr_reader,attr_writer} become public since Ruby 2.5

Browse source 
https://bugs.ruby-lang.org/issues/14132
This commit is contained in:
Ryuta Kamizono 2018-12-21 02:05:27 +09:00
parent 8034dde023
commit d5699198a4
8 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
activemodel/lib/active_model/validations/acceptance.rb
View file

@ -55,8 +55,8 @@ module ActiveModel
attr_readers = attributes.reject { |name| klass.attribute_method?(name) }
attr_writers = attributes.reject { |name| klass.attribute_method?("#{name}=") }
klass.define_attribute_methods
klass.send(:attr_reader, *attr_readers)
klass.send(:attr_writer, *attr_writers)
klass.attr_reader(*attr_readers)
klass.attr_writer(*attr_writers)
end
private

4
activemodel/lib/active_model/validations/confirmation.rb
View file

@ -19,11 +19,11 @@ module ActiveModel
private
def setup!(klass)
klass.send(:attr_reader, *attributes.map do |attribute|
klass.attr_reader(*attributes.map do |attribute|
:"#{attribute}_confirmation" unless klass.method_defined?(:"#{attribute}_confirmation")
end.compact)
klass.send(:attr_writer, *attributes.map do |attribute|
klass.attr_writer(*attributes.map do |attribute|
:"#{attribute}_confirmation" unless klass.method_defined?(:"#{attribute}_confirmation=")
end.compact)
end

2
activemodel/lib/active_model/validator.rb
View file

@ -90,7 +90,7 @@ module ActiveModel
# class MyValidator < ActiveModel::Validator
# def initialize(options={})
# super
# options[:class].send :attr_accessor, :custom_attribute
# options[:class].attr_accessor :custom_attribute
# end
# end
class Validator

2
activerecord/test/cases/validations/absence_validation_test.rb
View file

@ -61,7 +61,7 @@ class AbsenceValidationTest < ActiveRecord::TestCase
def test_validates_absence_of_virtual_attribute_on_model
repair_validations(Interest) do
Interest.send(:attr_accessor, :token)
Interest.attr_accessor(:token)
Interest.validates_absence_of(:token)
interest = Interest.create!(topic: "Thought Leadering")

2
activerecord/test/cases/validations/length_validation_test.rb
View file

@ -64,7 +64,7 @@ class LengthValidationTest < ActiveRecord::TestCase
def test_validates_length_of_virtual_attribute_on_model
repair_validations(Pet) do
Pet.send(:attr_accessor, :nickname)
Pet.attr_accessor(:nickname)
Pet.validates_length_of(:name, minimum: 1)
Pet.validates_length_of(:nickname, minimum: 1)

2
activerecord/test/cases/validations/presence_validation_test.rb
View file

@ -69,7 +69,7 @@ class PresenceValidationTest < ActiveRecord::TestCase
def test_validates_presence_of_virtual_attribute_on_model
repair_validations(Interest) do
Interest.send(:attr_accessor, :abbreviation)
Interest.attr_accessor(:abbreviation)
Interest.validates_presence_of(:topic)
Interest.validates_presence_of(:abbreviation)

4
railties/test/generators/api_app_generator_test.rb
View file

@ -14,9 +14,9 @@ class ApiAppGeneratorTest < Rails::Generators::TestCase
super
Kernel.silence_warnings do
Thor::Base.shell.send(:attr_accessor, :always_force)
Thor::Base.shell.attr_accessor :always_force
@shell = Thor::Base.shell.new
@shell.send(:always_force=, true)
@shell.always_force = true
end
end

4
railties/test/generators/shared_generator_tests.rb
View file

@ -10,9 +10,9 @@ module SharedGeneratorTests
Rails::Generators::AppGenerator.instance_variable_set("@desc", nil)
Kernel.silence_warnings do
Thor::Base.shell.send(:attr_accessor, :always_force)
Thor::Base.shell.attr_accessor :always_force
@shell = Thor::Base.shell.new
@shell.send(:always_force=, true)
@shell.always_force = true
end
end