kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Fix "warning: instance variable @defined_root not initialized"

Browse source 
Currently, the following error is shows only when run the test using
`bin/test`.

```
./bin/test -w test/template/log_subscriber_test.rb
Run options: --seed 17167

# Running:

/rails/actionview/test/template/log_subscriber_test.rb:34: warning: instance variable @defined_root not initialized
```

In `AVLogSubscriberTest`, if the `Rails.root` is not defined, define the
method and undef it in teardown.
https://github.com/rails/rails/blob/master/actionview/test/template/log_subscriber_test.rb#L21..L33

However, in `bin/test`, `Rails.root` is defined, which results in referring to
uninitialized variables and warnings.
This commit is contained in:
yuuji.yaginuma 2017-11-02 09:58:54 +09:00
parent b001fa5e29
commit d5defda77f
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
actionview/test/template/log_subscriber_test.rb
View file

@ -30,7 +30,7 @@ class AVLogSubscriberTest < ActiveSupport::TestCase
ActiveSupport::LogSubscriber.log_subscribers.clear
# We need to undef `root`, RenderTestCases don't want this to be defined
Rails.instance_eval { undef :root } if @defined_root
Rails.instance_eval { undef :root } if defined?(@defined_root)
end
def set_logger(logger)