kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Merge pull request #29533 from jdelStrother/missing_url_formats

Browse source 
Fix missing formats in route-set URLs
This commit is contained in:
Richard Schneeman 2017-06-27 19:41:11 -05:00 committed by GitHub
commit d766b64b7e
2 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
actionpack/lib/action_dispatch/routing/route_set.rb
View file

@ -279,6 +279,8 @@ module ActionDispatch
if args.size < path_params_size
path_params -= controller_options.keys
path_params -= result.keys
else
path_params = path_params.dup
end
inner_options.each_key do |key|
path_params.delete(key)

9
actionpack/test/dispatch/routing/route_set_test.rb
View file

@ -138,6 +138,15 @@ module ActionDispatch
assert_equal "/a/users/1", url_helpers.user_path(1, foo: "a")
end
test "implicit path components consistently return the same result" do
draw do
resources :users, to: SimpleApp.new("foo#index")
end
assert_equal "/users/1.json", url_helpers.user_path(1, :json)
assert_equal "/users/1.json", url_helpers.user_path(1, format: :json)
assert_equal "/users/1.json", url_helpers.user_path(1, :json)
end
private
def draw(&block)
@set.draw(&block)