kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Merge pull request #39494 from jonathanhefner/pathparser-lazy-regex

Browse source 
Lazily build path regex in PathParser
This commit is contained in:
Kasper Timm Hansen 2020-06-01 14:29:53 +02:00 committed by GitHub
commit d8d32f2535
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
actionview/lib/action_view/template/resolver.rb
View file

@ -36,10 +36,6 @@ module ActionView
end end
class PathParser # :nodoc: class PathParser # :nodoc:
def initialize
@regex = build_path_regex
end
def build_path_regex def build_path_regex
handlers = Template::Handlers.extensions.map { |x| Regexp.escape(x) }.join("|") handlers = Template::Handlers.extensions.map { |x| Regexp.escape(x) }.join("|")
formats = Template::Types.symbols.map { |x| Regexp.escape(x) }.join("|") formats = Template::Types.symbols.map { |x| Regexp.escape(x) }.join("|")
@ -60,6 +56,7 @@ module ActionView
end end
def parse(path) def parse(path)
@regex ||= build_path_regex
match = @regex.match(path) match = @regex.match(path)
{ {
prefix: match[:prefix] || "", prefix: match[:prefix] || "",

2
railties/test/application/rendering_test.rb
View file

@ -77,7 +77,9 @@ module ApplicationTests
source source
end end
end end
ActiveSupport.on_load :action_view do
ActionView::Template.register_template_handler(:rubby, RubbyHandler) ActionView::Template.register_template_handler(:rubby, RubbyHandler)
end
RUBY RUBY
get "/" get "/"