mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
Fix require_dependency
message format
`depend_on` message format is `"No such file to load -- %s.rb"`. But `require_dependency` message is missing `.rb` suffix. ``` % git grep -n 'No such file to load' actionview/test/actionpack/abstract/helper_test.rb:112: assert_equal "No such file to load -- very_invalid_file_name.rb", e.message activesupport/lib/active_support/dependencies.rb:245: def require_dependency(file_name, message = "No such file to load -- %s.rb") activesupport/lib/active_support/dependencies.rb:333: def depend_on(file_name, message = "No such file to load -- %s.rb") ```
This commit is contained in:
parent
1b795f5f0b
commit
d99b3848bb
2 changed files with 2 additions and 2 deletions
|
@ -109,7 +109,7 @@ module AbstractController
|
||||||
class InvalidHelpersTest < ActiveSupport::TestCase
|
class InvalidHelpersTest < ActiveSupport::TestCase
|
||||||
def test_controller_raise_error_about_real_require_problem
|
def test_controller_raise_error_about_real_require_problem
|
||||||
e = assert_raise(LoadError) { AbstractInvalidHelpers.helper(:invalid_require) }
|
e = assert_raise(LoadError) { AbstractInvalidHelpers.helper(:invalid_require) }
|
||||||
assert_equal "No such file to load -- very_invalid_file_name", e.message
|
assert_equal "No such file to load -- very_invalid_file_name.rb", e.message
|
||||||
end
|
end
|
||||||
|
|
||||||
def test_controller_raise_error_about_missing_helper
|
def test_controller_raise_error_about_missing_helper
|
||||||
|
|
|
@ -242,7 +242,7 @@ module ActiveSupport #:nodoc:
|
||||||
# resolution deterministic for constants with the same relative name in
|
# resolution deterministic for constants with the same relative name in
|
||||||
# different namespaces whose evaluation would depend on load order
|
# different namespaces whose evaluation would depend on load order
|
||||||
# otherwise.
|
# otherwise.
|
||||||
def require_dependency(file_name, message = "No such file to load -- %s")
|
def require_dependency(file_name, message = "No such file to load -- %s.rb")
|
||||||
file_name = file_name.to_path if file_name.respond_to?(:to_path)
|
file_name = file_name.to_path if file_name.respond_to?(:to_path)
|
||||||
unless file_name.is_a?(String)
|
unless file_name.is_a?(String)
|
||||||
raise ArgumentError, "the file name must either be a String or implement #to_path -- you passed #{file_name.inspect}"
|
raise ArgumentError, "the file name must either be a String or implement #to_path -- you passed #{file_name.inspect}"
|
||||||
|
|
Loading…
Reference in a new issue