1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00

Ignore illegal seeks on body rewind. Catches CGI errors depending on your httpd. Closes #10404 [Curtis Hawthorne]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8327 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
This commit is contained in:
Jeremy Kemper 2007-12-07 04:20:20 +00:00
parent 2766f7629f
commit db885e81b9
2 changed files with 17 additions and 1 deletions

View file

@ -588,7 +588,13 @@ module ActionController
end end
raise EOFError, "bad boundary end of body part" unless boundary_end=~/--/ raise EOFError, "bad boundary end of body part" unless boundary_end=~/--/
body.rewind if body.respond_to?(:rewind) begin
body.rewind if body.respond_to?(:rewind)
rescue Errno::ESPIPE
# Handles exceptions raised by input streams that cannot be rewound
# such as when using plain CGI under Apache
end
params params
end end
end end

View file

@ -736,6 +736,16 @@ class MultipartRequestParameterParsingTest < Test::Unit::TestCase
assert ('a' * 20480) == file.read assert ('a' * 20480) == file.read
end end
uses_mocha "test_no_rewind_stream" do
def test_no_rewind_stream
# Ensures that parse_multipart_form_parameters works with streams that cannot be rewound
file = File.open(File.join(FIXTURE_PATH, 'large_text_file'), 'rb')
file.expects(:rewind).raises(Errno::ESPIPE)
params = ActionController::AbstractRequest.parse_multipart_form_parameters(file, 'AaB03x', file.stat.size, {})
assert_not_equal 0, file.pos # file was not rewound after reading
end
end
def test_binary_file def test_binary_file
params = process('binary_file') params = process('binary_file')
assert_equal %w(file flowers foo), params.keys.sort assert_equal %w(file flowers foo), params.keys.sort