From dbb3ca338e21d08e18163989cf05cfa042c850ea Mon Sep 17 00:00:00 2001 From: Daniel Colson Date: Tue, 22 Sep 2020 18:50:15 -0400 Subject: [PATCH] Add a note about PR approvals [ci skip] Sometimes folks get "Approved" reviews from other contributors who do not have merge access. This can come across as an official endorsement, especially in cases where the approval comes from someone who is a member of the Rails org, but is not on the core or committer team (me, for example). This paragraph is meant to document both that "Approved" is not the same as an official endorsement, and that we prefer people don't mark PRs as "Approved" in the first place. --- guides/source/contributing_to_ruby_on_rails.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/guides/source/contributing_to_ruby_on_rails.md b/guides/source/contributing_to_ruby_on_rails.md index 7add66663d..260bb9bddb 100644 --- a/guides/source/contributing_to_ruby_on_rails.md +++ b/guides/source/contributing_to_ruby_on_rails.md @@ -621,6 +621,11 @@ While you're waiting for feedback on your pull request, open up a few other pull requests and give someone else some! I'm sure they'll appreciate it in the same way that you appreciate feedback on your patches. +Note that your pull request may be marked as "Approved" by somebody who does not +have access to merge it. Further changes may still be required before members of +the core or committer teams accept it. To prevent confusion, when giving +feedback on someone else's pull request please avoid marking it as "Approved." + ### Iterate as Necessary It's entirely possible that the feedback you get will suggest changes. Don't get discouraged: the whole point of contributing to an active open source project is to tap into the knowledge of the community. If people are encouraging you to tweak your code, then it's worth making the tweaks and resubmitting. If the feedback is that your code doesn't belong in the core, you might still think about releasing it as a gem.