From 7e7d6ccf344d3cb42b836e22e1381269f55b67d2 Mon Sep 17 00:00:00 2001 From: Vipul A M Date: Sat, 12 Nov 2016 13:14:49 -0500 Subject: [PATCH] Changelog edits --- actioncable/CHANGELOG.md | 8 ++++---- actionpack/CHANGELOG.md | 2 +- actionview/CHANGELOG.md | 6 +++--- activerecord/CHANGELOG.md | 14 +++++++------- 4 files changed, 15 insertions(+), 15 deletions(-) diff --git a/actioncable/CHANGELOG.md b/actioncable/CHANGELOG.md index d70d32ce07..2c84d3158f 100644 --- a/actioncable/CHANGELOG.md +++ b/actioncable/CHANGELOG.md @@ -1,7 +1,7 @@ * Permit same-origin connections by default. - New option `config.action_cable.allow_same_origin_as_host = false` - to disable. + Added new option `config.action_cable.allow_same_origin_as_host = false` + to disable this behaviour. *Dávid Halász*, *Matthew Draper* @@ -13,7 +13,7 @@ *Vladimir Dementyev* -* Buffer writes to websocket connections, to avoid blocking threads +* Buffer now writes to websocket connections, to avoid blocking threads that could be doing more useful things. *Matthew Draper*, *Tinco Andringa* @@ -23,7 +23,7 @@ *Tinco Andringa* -* Add ActiveSupport::Notifications hook to Broadcaster#broadcast. +* Add `ActiveSupport::Notifications` hook to `Broadcaster#broadcast`. *Matthew Wear* diff --git a/actionpack/CHANGELOG.md b/actionpack/CHANGELOG.md index b539c893e3..37ccef2a78 100644 --- a/actionpack/CHANGELOG.md +++ b/actionpack/CHANGELOG.md @@ -10,7 +10,7 @@ *Yuji Yaginuma* -* Allow keys not found in RACK_KEY_TRANSLATION for setting the environment when rendering +* Allow keys not found in `RACK_KEY_TRANSLATION` for setting the environment when rendering arbitrary templates. *Sammy Larbi* diff --git a/actionview/CHANGELOG.md b/actionview/CHANGELOG.md index 67bd9b5c8f..6e6ce64e72 100644 --- a/actionview/CHANGELOG.md +++ b/actionview/CHANGELOG.md @@ -2,12 +2,12 @@ *Rafael Mendonça França* -* Render now accepts any keys for locals, including reserved words +* Render now accepts any keys for locals, including reserved keywords. Only locals with valid variable names get set directly. Others - will still be available in local_assigns. + will still be available in `local_assigns`. - Example of render with reserved words: + Example of render with reserved keywords: ```erb <%= render "example", class: "text-center", message: "Hello world!" %> diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md index dd2a1b4b19..8efefe9b2e 100644 --- a/activerecord/CHANGELOG.md +++ b/activerecord/CHANGELOG.md @@ -1,4 +1,4 @@ -* Add `stat` method to `ActiveRecord::ConnectionAdapters::ConnectionPool` +* Added `stat` method to `ActiveRecord::ConnectionAdapters::ConnectionPool` Example: @@ -10,18 +10,18 @@ * Avoid `unscope(:order)` when `limit_value` is presented for `count`. If `limit_value` is presented, records fetching order is very important - for performance. Should not unscope the order in the case. + for performance. We should not unscope the order in the case. *Ryuta Kamizono* -* Fix an Active Record DateTime field NoMethodError caused by incomplete +* Fix an Active Record `DateTime` field `NoMethodError` caused by incomplete datetime. Fixes #24195. *Sen Zhang* -* Allow `slice` to take an array of methods (without need for splatting). +* Allow `slice` to take an array of methods(without the need for splatting). *Cohen Carlisle* @@ -37,12 +37,12 @@ *Prathamesh Sonpatki* -* Optimistic locking: Added ability update locking_column value. - Ignore optimistic locking if update with new locking_column value. +* Optimistic locking: Added ability to update `locking_column` value. + Ignore optimistic locking if trying to update with new `locking_column` value. *bogdanvlviv* -* Fixed: Optimistic locking does not work well with null in the database. +* Fixed: Optimistic locking does not work well with `null` in the database. Fixes #26024