kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Flesh out conductor interface

Browse source
This commit is contained in:
David Heinemeier Hansson 2018-09-27 17:39:13 -07:00
parent ab92058bbd
commit e1486aa353
10 changed files with 87 additions and 43 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
app/controllers/action_mailroom/inbound_emails_controller.rb
View file

@ -2,38 +2,15 @@
# TODO: Spam/malware catching? # TODO: Spam/malware catching?
# TODO: Specific bounces for SMTP good citizenship: 200/404/400 # TODO: Specific bounces for SMTP good citizenship: 200/404/400
class ActionMailroom::InboundEmailsController < ActionController::Base class ActionMailroom::InboundEmailsController < ActionController::Base
layout "action_mailroom"
skip_forgery_protection skip_forgery_protection
before_action :ensure_development_env, except: :create
before_action :require_rfc822_message, only: :create before_action :require_rfc822_message, only: :create
def index
@inbound_emails = ActionMailroom::InboundEmail.order(created_at: :desc)
end
def new
end
def show
@inbound_email = ActionMailroom::InboundEmail.find(params[:id])
end
def create def create
ActionMailroom::InboundEmail.create_from_raw_email!(params[:message]) ActionMailroom::InboundEmail.create_from_raw_email!(params[:message])
head :created
respond_to do |format|
format.html { redirect_to main_app.rails_new_inbound_email_url }
format.any { head :created }
end
end end
private private
# TODO: Should probably separate the admin interface and do more to ensure that it isn't exposed to the web
def ensure_development_env
head :forbidden unless Rails.env.development?
end
def require_rfc822_message def require_rfc822_message
head :unsupported_media_type unless params.require(:message).content_type == 'message/rfc822' head :unsupported_media_type unless params.require(:message).content_type == 'message/rfc822'
end end

30
app/controllers/rails/conductor/action_mailroom/inbound_emails_controller.rb Normal file
View file

@ -0,0 +1,30 @@
class Rails::Conductor::ActionMailroom::InboundEmailsController < Rails::Conductor::BaseController
def index
@inbound_emails = ActionMailroom::InboundEmail.order(created_at: :desc)
end
def new
end
def show
@inbound_email = ActionMailroom::InboundEmail.find(params[:id])
end
def create
inbound_email = create_inbound_email(new_mail)
redirect_to main_app.rails_conductor_inbound_email_url(inbound_email)
end
private
def new_mail
Mail.new params.require(:mail).permit(:from, :to, :cc, :bcc, :subject, :body)
end
def create_inbound_email(mail)
ActionMailroom::InboundEmail.create! raw_email: new_raw_email(mail), message_id: mail.message_id
end
def new_raw_email(mail)
{ io: StringIO.new(new_mail.to_s), filename: 'inbound.eml', content_type: 'message/rfc822', identify: false }
end
end

10
app/controllers/rails/conductor/base_controller.rb Normal file
View file

@ -0,0 +1,10 @@
# TODO: Move this to Rails::Conductor gem
class Rails::Conductor::BaseController < ActionController::Base
layout "rails/conductor"
before_action :ensure_development_env
private
def ensure_development_env
head :forbidden unless Rails.env.development?
end
end

8
app/views/action_mailroom/inbound_emails/new.html.erb
View file

@ -1,8 +0,0 @@
<% provide :title, "Deliver new inbound email" %>
<h1>Deliver new inbound email</h1>
<%= form_with(url: main_app.rails_inbound_emails_url, remote: false) do |form| %>
<%= form.file_field :message, size: "150x50", autofocus: true %><br>
<%= form.submit "Deliver inbound email" %>
<% end %>

7
app/views/layouts/action_mailroom.html.erb
View file

@ -1,7 +0,0 @@
<html>
<head>
<title><%= yield :title %></title>
</head>
<body>
<%= yield %>
</html>

7
app/views/layouts/rails/conductor.html.erb Normal file
View file

@ -0,0 +1,7 @@
<html>
<head>
<title>Rails Conductor: <%= yield :title %></title>
</head>
<body>
<%= yield %>
</html>

4
app/views/action_mailroom/inbound_emails/index.html.erb → app/views/rails/conductor/action_mailroom/inbound_emails/index.html.erb
View file

@ -6,10 +6,10 @@
<tr><th>Message ID</th><th>Status</th></tr> <tr><th>Message ID</th><th>Status</th></tr>
<% @inbound_emails.each do |inbound_email| %> <% @inbound_emails.each do |inbound_email| %>
<tr> <tr>
<td><%= link_to inbound_email.message_id, main_app.rails_inbound_email_path(inbound_email) %></td> <td><%= link_to inbound_email.message_id, main_app.rails_conductor_inbound_email_path(inbound_email) %></td>
<td><%= inbound_email.status %></td> <td><%= inbound_email.status %></td>
</tr> </tr>
<% end %> <% end %>
</table> </table>
<%= link_to "Deliver new inbound email", main_app.new_rails_inbound_email_path %> <%= link_to "Deliver new inbound email", main_app.new_rails_conductor_inbound_email_path %>

27
app/views/rails/conductor/action_mailroom/inbound_emails/new.html.erb Normal file
View file

@ -0,0 +1,27 @@
<% provide :title, "Deliver new inbound email" %>
<h1>Deliver new inbound email</h1>
<%= form_with(url: main_app.rails_conductor_inbound_emails_path, scope: :mail, local: true) do |form| %>
<div>
<%= form.label :from, "From" %><br>
<%= form.text_field :from %>
</div>
<div>
<%= form.label :to, "To" %><br>
<%= form.text_field :to %>
</div>
<div>
<%= form.label :subject, "Subject" %><br>
<%= form.text_field :subject %>
</div>
<div>
<%= form.label :body, "Body" %><br>
<%= form.text_area :body, size: "40x20" %>
</div>
<%= form.submit "Deliver inbound email" %>
<% end %>

5
app/views/action_mailroom/inbound_emails/show.html.erb → app/views/rails/conductor/action_mailroom/inbound_emails/show.html.erb
View file

@ -6,3 +6,8 @@
<li>Retry</li> <li>Retry</li>
<li>Incinerate</li> <li>Incinerate</li>
</ul> </ul>
<details>
<summary>Full email source</summary>
<pre><%= @inbound_email.source %></pre>
</details>

7
config/routes.rb
View file

@ -1,7 +1,10 @@
# frozen_string_literal: true # frozen_string_literal: true
Rails.application.routes.draw do Rails.application.routes.draw do
scope 'rails/action_mailroom', module: 'action_mailroom' do post "/rails/action_mailroom/inbound_emails" => "action_mailroom/inbound_emails#create", as: :rails_inbound_emails
resources :inbound_emails, as: :rails_inbound_emails
# TODO: Should these be mounted within the engine only?
scope "rails/conductor/action_mailroom/", module: "rails/conductor/action_mailroom" do
resources :inbound_emails, as: :rails_conductor_inbound_emails
end end
end end