kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Rails 5.1 point type should not raise exception if empty string is provided as value

Browse source
This commit is contained in:
bUg 2016-05-15 15:00:10 +03:00 committed by Alexander Grebennik
parent 0827f9932f
commit e3cd321d4b
2 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
activerecord/lib/active_record/connection_adapters/postgresql/oid/rails_5_1_point.rb
View file

@ -14,6 +14,8 @@ module ActiveRecord
def cast(value) def cast(value)
case value case value
when ::String when ::String
return if value.blank?
if value[0] == '(' && value[-1] == ')' if value[0] == '(' && value[-1] == ')'
value = value[1...-1] value = value[1...-1]
end end

7
activerecord/test/cases/adapters/postgresql/geometric_test.rb
View file

@ -104,6 +104,13 @@ class PostgresqlPointTest < ActiveRecord::PostgreSQLTestCase
assert_equal ActiveRecord::Point.new(1, 2), p.x assert_equal ActiveRecord::Point.new(1, 2), p.x
end end
def test_empty_string_assignment
assert_nothing_raised { PostgresqlPoint.new(x: "") }
p = PostgresqlPoint.new(x: "")
assert_equal nil, p.x
end
def test_array_of_points_round_trip def test_array_of_points_round_trip
expected_value = [ expected_value = [
ActiveRecord::Point.new(1, 2), ActiveRecord::Point.new(1, 2),