kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Fix assertion count after 69e1bb52.

Browse source 
When changing the generated integration tests to assert redirects with
an absolute path this redirection check in `assert_redirected_to` against
the absolute response location would now pass:
af245aaf3a/actionpack/lib/action_dispatch/testing/assertions/response.rb (L55)

Thus we'd break early instead of hitting `assert_operator` and have
2 fewer assertions per `assert_redirected_to` as `assert_operator`
is composed of 2 assertions internally:
4e146b1515/lib/minitest/assertions.rb (L254-L258)

Deduct 2 assertions for 2 redirects taking the expected count down by 4
in total for the two failing tests.
This commit is contained in:
Kasper Timm Hansen 2016-05-28 22:26:45 +02:00
parent af245aaf3a
commit e45f388eb4
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
railties/test/application/rake_test.rb
View file

@ -287,7 +287,7 @@ module ApplicationTests
RAILS_ENV=test bin/rails db:migrate test` RAILS_ENV=test bin/rails db:migrate test`
end end
assert_match(/7 runs, 12 assertions, 0 failures, 0 errors/, output) assert_match(/7 runs, 9 assertions, 0 failures, 0 errors/, output)
assert_no_match(/Errors running/, output) assert_no_match(/Errors running/, output)
end end
@ -318,7 +318,7 @@ module ApplicationTests
RAILS_ENV=test bin/rails db:migrate test` RAILS_ENV=test bin/rails db:migrate test`
end end
assert_match(/7 runs, 12 assertions, 0 failures, 0 errors/, output) assert_match(/7 runs, 9 assertions, 0 failures, 0 errors/, output)
assert_no_match(/Errors running/, output) assert_no_match(/Errors running/, output)
end end