kotovalexarian-likes-github/rails--rails
1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00
Code Releases Activity

Use attribute_before_type_cast in the internal

Browse source 
`read_attribute_before_type_cast` has become bit slower since #40395.
This commit is contained in:
Ryuta Kamizono 2020-10-27 16:32:35 +09:00
parent 13bd289b44
commit e47068c3f3
3 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
activemodel/lib/active_model/validations/numericality.rb
View file

@ -115,7 +115,7 @@ module ActiveModel
if record.respond_to?(came_from_user) if record.respond_to?(came_from_user)
if record.public_send(came_from_user) if record.public_send(came_from_user)
raw_value = record.read_attribute_before_type_cast(attr_name) raw_value = record.public_send(:"#{attr_name}_before_type_cast")
elsif record.respond_to?(:read_attribute) elsif record.respond_to?(:read_attribute)
raw_value = record.read_attribute(attr_name) raw_value = record.read_attribute(attr_name)
end end

2
activerecord/lib/active_record/attribute_methods/primary_key.rb
View file

@ -31,7 +31,7 @@ module ActiveRecord
# Returns the primary key column's value before type cast. # Returns the primary key column's value before type cast.
def id_before_type_cast def id_before_type_cast
read_attribute_before_type_cast(@primary_key) attribute_before_type_cast(@primary_key)
end end
# Returns the primary key column's previous value. # Returns the primary key column's previous value.

4
activerecord/lib/active_record/locking/optimistic.rb
View file

@ -89,7 +89,7 @@ module ActiveRecord
begin begin
locking_column = self.class.locking_column locking_column = self.class.locking_column
previous_lock_value = read_attribute_before_type_cast(locking_column) previous_lock_value = attribute_before_type_cast(locking_column)
attribute_names = attribute_names.dup if attribute_names.frozen? attribute_names = attribute_names.dup if attribute_names.frozen?
attribute_names << locking_column attribute_names << locking_column
@ -121,7 +121,7 @@ module ActiveRecord
affected_rows = self.class._delete_record( affected_rows = self.class._delete_record(
@primary_key => id_in_database, @primary_key => id_in_database,
locking_column => read_attribute_before_type_cast(locking_column) locking_column => attribute_before_type_cast(locking_column)
) )
if affected_rows != 1 if affected_rows != 1