1
0
Fork 0
mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00

Add params option for button_to

The parameters are rendered as hidden form fields within the generated
form. This is useful for when a record has multiple buttons associated
with it, each of which target the same controller method, but which
need to submit different attributes.
This commit is contained in:
Andy Waite 2013-05-05 12:32:00 +01:00
parent 539180cf8e
commit e6e0579def
3 changed files with 19 additions and 0 deletions

View file

@ -1,3 +1,8 @@
* Add `params` option to `button_to` form helper, which renders the given hash
as hidden form fields.
*Andy Waite*
* Development mode exceptions are rendered in text format in case of XHR request. * Development mode exceptions are rendered in text format in case of XHR request.
*Kir Shatrov* *Kir Shatrov*

View file

@ -213,6 +213,7 @@ module ActionView
# * <tt>:form</tt> - This hash will be form attributes # * <tt>:form</tt> - This hash will be form attributes
# * <tt>:form_class</tt> - This controls the class of the form within which the submit button will # * <tt>:form_class</tt> - This controls the class of the form within which the submit button will
# be placed # be placed
# * <tt>:params</tt> - Hash of parameters to be rendered as hidden fields within the form.
# #
# ==== Data attributes # ==== Data attributes
# #
@ -287,6 +288,7 @@ module ActionView
url = options.is_a?(String) ? options : url_for(options) url = options.is_a?(String) ? options : url_for(options)
remote = html_options.delete('remote') remote = html_options.delete('remote')
params = html_options.delete('params')
method = html_options.delete('method').to_s method = html_options.delete('method').to_s
method_tag = BUTTON_TAG_METHOD_VERBS.include?(method) ? method_tag(method) : ''.html_safe method_tag = BUTTON_TAG_METHOD_VERBS.include?(method) ? method_tag(method) : ''.html_safe
@ -310,6 +312,11 @@ module ActionView
end end
inner_tags = method_tag.safe_concat(button).safe_concat(request_token_tag) inner_tags = method_tag.safe_concat(button).safe_concat(request_token_tag)
if params
params.each do |name, value|
inner_tags.safe_concat tag(:input, type: "hidden", name: name, value: value.to_param)
end
end
content_tag('form', content_tag('div', inner_tags), form_options) content_tag('form', content_tag('div', inner_tags), form_options)
end end

View file

@ -160,6 +160,13 @@ class UrlHelperTest < ActiveSupport::TestCase
) )
end end
def test_button_to_with_params
assert_dom_equal(
%{<form action="http://www.example.com" class="button_to" method="post"><div><input type="submit" value="Hello" /><input type="hidden" name="foo" value="bar" /><input type="hidden" name="baz" value="quux" /></div></form>},
button_to("Hello", "http://www.example.com", params: {foo: :bar, baz: "quux"})
)
end
def test_link_tag_with_straight_url def test_link_tag_with_straight_url
assert_dom_equal %{<a href="http://www.example.com">Hello</a>}, link_to("Hello", "http://www.example.com") assert_dom_equal %{<a href="http://www.example.com">Hello</a>}, link_to("Hello", "http://www.example.com")
end end